Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Let prettier indent XML files #640

Merged
merged 2 commits into from Mar 3, 2020
Merged

Let prettier indent XML files #640

merged 2 commits into from Mar 3, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 1, 2020 •
edited

fixes #632

@pedrobaeza pedrobaeza requested a review from yajo March 1, 2020 10:37
pedrobaeza
pedrobaeza approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

simahawk
simahawk approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG judging from docs.
I'd like xmlSelfClosingSpace=true but that's another story 😜

@yajo
Copy link
Member

yajo commented Mar 2, 2020

Do you have a sample PR or diff to check the effect?

@sbidoul sbidoul changed the title Prettier xml whitespace sbi Let prettier indent XML files Mar 2, 2020
@sbidoul sbidoul force-pushed the prettier-xml-whitespace-sbi branch from 16c8cd4 to 98a1034 Compare March 2, 2020 09:06
@sbidoul
sample files: ignore whitespace between tags
17f2d40 
In order to let prettier indent xml
correctly, it has to consider whitespace between tag
as non significant. It should be
a safe default for odoo-related xml files.

fixes OCA#632
@sbidoul
sample files: bump @prettier/plugin-xml to 0.7.2
f6d3107
@sbidoul sbidoul force-pushed the prettier-xml-whitespace-sbi branch from 98a1034 to f6d3107 Compare March 2, 2020 09:07
@sbidoul
Copy link
Member Author

sbidoul commented Mar 2, 2020

I'd like xmlSelfClosingSpace=true but that's another story

@simahawk ok, no big deal for me, I reverted that commit.

@sbidoul sbidoul mentioned this pull request Mar 2, 2020
Merged
@sbidoul
Copy link
Member Author

sbidoul commented Mar 2, 2020

Do you have a sample PR or diff to check the effect?

I opened OCA/web#1540

@simahawk
Copy link
Contributor

simahawk commented Mar 3, 2020

@sbidoul the OCA/web PR got merged: shall we merge here?

@sbidoul sbidoul merged commit 2553ed8 into OCA:master Mar 3, 2020
@sbidoul sbidoul deleted the prettier-xml-whitespace-sbi branch March 3, 2020 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simahawk simahawk simahawk approved these changes

@moylop260 moylop260 moylop260 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@yajo yajo Awaiting requested review from yajo

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No so pretty XML formatting by prettier
6 participants
@sbidoul @yajo @simahawk @moylop260 @pedrobaeza @OCA-git-bot