Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Ignore lib/ wherever it stays #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore lib/ wherever it stays #641

wants to merge 1 commit into from

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Mar 3, 2020

Libs can be place in several paths depending on project's needs.
We should always ignore them.

Libs can be place in several paths depending on project's needs.
We should always ignore them.
@sbidoul
Copy link
Member

sbidoul commented Mar 7, 2020

@simahawk do you have a concrete example?

@simahawk
Copy link
Contributor Author

@sbidoul because you might want to put your static code inside something more meaningful instead of src which is there only because odoo assumes you use it when it looks up for JS translations.
Our use case is the WMS app: we serve static/wms and we like to sort of namespace it's path.

Not really mandatory but nice to have.
Also, I don't see which issue could you get by ignore lib wherever it stays. I think is the contrary.

@@ -5,7 +5,7 @@ exclude: |
# Maybe reactivate this when all README files include prettier ignore tags?
^README\.md$|
# Library files can have extraneous formatting (even minimized)
/static/(src/)?lib/|
lib/|
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we still enforce the static/ prefix?
Something like static/.*/lib/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants