Merge pull request #412 from Eficent/master-fix-tools-gen_addon_readm…

…e-desduplicate_manifest-reading [FIX] tools.gen_addon_readme: deduplicate manifest reading
OCA · Mar 21, 2019 · 3c2b03c · 3c2b03c
2 parents 92383c9 + 3d73928
commit 3c2b03c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/tools/gen_addon_readme.py b/tools/gen_addon_readme.py
@@ -295,14 +295,13 @@ def gen_addon_readme(
         addons.extend(find_addons(addons_dir))
     for addon_dir in addon_dirs:
         addon_name = os.path.basename(os.path.abspath(addon_dir))
-        manifest = read_manifest(addon_dir)
-        addons.append((addon_name, addon_dir, manifest))
-    readme_filenames = []
-    for addon_name, addon_dir, manifest in addons:
         try:
             manifest = read_manifest(addon_dir)
         except NoManifestFound:
             continue
+        addons.append((addon_name, addon_dir, manifest))
+    readme_filenames = []
+    for addon_name, addon_dir, manifest in addons:
         if not os.path.exists(
                 os.path.join(addon_dir, FRAGMENTS_DIR, 'DESCRIPTION.rst')):
             continue