Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in module description not properly displayed on app.store and in the list of local modules in an odoo instance. #112

Closed
lmignon opened this issue Aug 29, 2015 · 9 comments

Comments

@lmignon
Copy link
Sponsor Contributor

lmignon commented Aug 29, 2015

The module description is the key element to promote our modules. For modules under OCA, the rule is to put this description in a README.rst file following some specific guidelines. (https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#modules)
This file is used by github, odoo and odod.app.store to provide a nicely formatted description of our modules.
When trying to get a nice description of the mis_builder module under all these places I've observed the following problems:

  • If you references some images in your description (images stored in static/src/description), even if your file looks fine on github, images are missing in odoo and app.store.
  • The licence bagde is not displayed in the app.store

File under github:
image

Description in Odoo:
image

Description app.store:
image

The problem for the images is that the rules to be correctly rendered are not the same depending of the target.

  • For github the path to the image must be /static/..../my_img.png
  • For Odoo /my_module/static/..../my_img.png
  • For app.store my_img.png

For the licence badge, when the file is converted to html5, the image is put directly under the body element and not into a section element. My hypothesis is that the app.store keeps only from the conversion result the 'section' elements (This hypothesis will be verified once OCA/sale-workflow#54 will be merged).

For mis builder, I've solved the problem by manually generating an html description from the REAMDE.rst file. (OCA/account-financial-reporting@6db1e21)
The description is now correctly formatted everywhere.

This kind of process can be easily automated and launched in the after_success script by travis but is it really the good solution?

@pedrobaeza
Copy link
Member

Didn't you find any solution without the HTML?

@dreispt
Copy link
Sponsor Member

dreispt commented Aug 30, 2015

AFAIK the appstore was build to work with the module /description subdir.
But the README at the root of the modules needs different paths.
I feel that we should ask Olivier's involvement, and filing an Issue is probably the best way.

@pedrobaeza
Copy link
Member

Yeah, we can try that

@lmignon lmignon changed the title Images in module description not properly on app.store and the list of local module in an odoo instance. Images in module description not properly displayed on app.store and in the list of local module in an odoo instance. Aug 31, 2015
@lmignon lmignon changed the title Images in module description not properly displayed on app.store and in the list of local module in an odoo instance. Images in module description not properly displayed on app.store and in the list of local modules in an odoo instance. Aug 31, 2015
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Aug 31, 2015

@dreispt @pedrobaeza For sure, the problems come from Odoo. I'll fill an issue on Odoo.

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Aug 31, 2015

issue on Odoo: odoo/odoo#8300

@moylop260
Copy link
Contributor

USING .. figure:: instead of image is fixed.

@pedrobaeza
Copy link
Member

But it's documented on MT template?

@eLBati
Copy link
Member

eLBati commented Jul 14, 2016

@pedrobaeza I proposed this #204

@pedrobaeza
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants