-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images in module description not properly displayed on app.store and in the list of local modules in an odoo instance. #112
Comments
Didn't you find any solution without the HTML? |
AFAIK the appstore was build to work with the module |
Yeah, we can try that |
@dreispt @pedrobaeza For sure, the problems come from Odoo. I'll fill an issue on Odoo. |
issue on Odoo: odoo/odoo#8300 |
USING |
But it's documented on MT template? |
@pedrobaeza I proposed this #204 |
Thanks! |
The module description is the key element to promote our modules. For modules under OCA, the rule is to put this description in a
README.rst
file following some specific guidelines. (https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#modules)This file is used by github, odoo and odod.app.store to provide a nicely formatted description of our modules.
When trying to get a nice description of the mis_builder module under all these places I've observed the following problems:
File under github:
![image](https://cloud.githubusercontent.com/assets/544090/9561017/50df23f2-4e34-11e5-85a1-0f2830c8b115.png)
Description in Odoo:
![image](https://cloud.githubusercontent.com/assets/544090/9561021/8e558762-4e34-11e5-916e-5e5478a05b13.png)
Description app.store:
![image](https://cloud.githubusercontent.com/assets/544090/9561026/eeb90f16-4e34-11e5-93d5-ac840d2389e2.png)
The problem for the images is that the rules to be correctly rendered are not the same depending of the target.
/static/..../my_img.png
/my_module/static/..../my_img.png
my_img.png
For the licence badge, when the file is converted to html5, the image is put directly under the body element and not into a section element. My hypothesis is that the app.store keeps only from the conversion result the 'section' elements (This hypothesis will be verified once OCA/sale-workflow#54 will be merged).
For mis builder, I've solved the problem by manually generating an html description from the REAMDE.rst file. (OCA/account-financial-reporting@6db1e21)
The description is now correctly formatted everywhere.
This kind of process can be easily automated and launched in the after_success script by travis but is it really the good solution?
The text was updated successfully, but these errors were encountered: