[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices #54

pedrobaeza · 2014-10-31T13:42:12Z

Recalculation of sale order lines prices on demand

This module adds a button on sale orders below pricelist that recalculates the
prices of the order lines that contain a product in them.

It is launched manually as a button to get the user decide if he/she wants to
recalculate prices when pricelist is changed.

Usage

Inside a sale order, you can click in any moment a button called
"(Recalculate prices)", that is next to the pricelist selection, to launch
a recalculation of all the prices of the lines, losing previous custom prices.

Known issues / Roadmap

In a sale order with lot of lines, the recalculation may slow down, because
sale general data (amount untaxed, amount taxed...) are recalculated for
each line.

sbidoul · 2014-10-31T13:49:07Z

Thanks @pedrobaeza!

I see this module calls product_id_change while the other that was mentioned on the mailing list calss price_get. Therefore this one does a bit more than updating the price.

I'm not sure which of the two approaches is better, although I would lend towards a change of the price only, which better correspond to the button name.

What do people think?

pedrobaeza · 2014-10-31T13:55:18Z

Well, in fact, call product_id_change is the same as get the price, but avoiding possible side effects if the way the price is calculated changes. The same method is called when you change quantity, so you are not going to find things in the line that you don't want to get.

I do it this way because you can have other fields like discount modified (with module product_visible_discount), and the other method doesn't change that.

clonedagain · 2014-11-01T22:34:05Z

Code LGTM at first glance. I'll try to test on Monday

rvalyi · 2014-11-02T00:27:12Z

I just want to add that such code will be extremely slow on large orders line with 50+ lines because of the write on every line that will trigger a recomputation of order fields for each line.

This is okay as a 1st approach but would probably be better refactored later to collect the prices and then call a single write at the order level (with nested lines values) while disabling field recomputation and enabling them back after. We did that kind of trick for a customer in 6.1 for purchase and typically went from 15+ minutes to 20 secs on 70+ order lines (disclaimer: our localization adds a few computed fields; but still...)

pedrobaeza · 2014-11-02T11:47:38Z

Hi, @rvalyi. Thanks for the suggestion. I will implement your approach, because indeed it scalates better. I let you know when I have it ready.

vrenaville · 2014-11-03T07:44:47Z

This module is very similar as our module, so I approve this 👍

pedrobaeza · 2014-11-03T08:38:46Z

@rvalyi Can you point me to which context key defers the computation of fields?, because I can't remember it.

clonedagain · 2014-11-25T08:51:11Z

@vrenaville do you think you could backport this to v7 so that we have a smooth migration path please?

adrienpeiffer · 2014-11-26T20:41:42Z

👍
Code review and tests with more than 200 lines in the same sale order.

StefanRijnhart · 2015-01-21T17:09:17Z

sale_order_recalculate_prices/models/sale_order.py

+                        True, record.date_order, False,
+                        record.fiscal_position.id, False,
+                        context=self.env.context)
+                    line.write(res['value'])


Can you add the names of the keyword arguments in this call to product_id_change, in order to preserve compatibility with overrides that change the order of the keyword arguments?
Doesn't the API compatibility layer take care of the context argument?

For information, we encountered some issues with the same kind of code.. odoo/odoo#4698

StefanRijnhart · 2015-01-21T17:09:35Z

Is this still work in progress, as the tag implies?

pedrobaeza · 2015-01-23T23:21:05Z

@StefanRijnhart, do you have any clue about what @rvalyi mentions?

yvaucher · 2015-04-24T15:56:57Z

sale_order_recalculate_prices/README.rst

@@ -0,0 +1,8 @@
+Recalculation of sale order lines prices on demand


Can we prettify this using OCA template ?

StefanRijnhart · 2015-04-24T16:10:40Z

@pedrobaeza: looks like you could look at setting 'recompute' to False in the context, if you think that is safe.

pedrobaeza · 2015-08-28T06:49:23Z

This one was one of my old pendings. @StefanRijnhart, I have tried the context argument, but it seems it's not working. Anyway, I prefer not to put it, because it can have side effects on other added computed fields on sale order lines. I have put a note on known issues.

I have also added some tests. Please review.

lmignon · 2015-08-28T08:20:55Z

sale_order_price_recalculation/__openerp__.py

+{
+    "name": "Price recalculation in sales orders",
+    "version": "8.0.1.0.0",
+    "depends": [


the licence miss

(fixed below)

lmignon · 2015-08-28T08:31:21Z

+1 with @gurneyalex concern

pedrobaeza · 2015-08-28T10:39:47Z

Changes done!

pedrobaeza · 2015-08-28T10:46:48Z

All changes done!

gurneyalex · 2015-08-28T11:20:42Z

👍

gurneyalex · 2015-08-28T11:21:24Z

@lmignon if it's ok with you I'll merge.

lmignon · 2015-08-28T16:23:38Z

sale_order_price_recalculation/models/sale_order.py

+                qty=line.product_uom_qty, uom=line.product_uom.id,
+                qty_uos=line.product_uos_qty, uos=line.product_uos.id,
+                name=line.name, partner_id=order.partner_id.id, lang=False,
+                update_tax=True, date_order=order.date_order, packaging=False,


IMO, you should also provide the packaging from the line even if it's not used by default but if the method is redefined by others modules, the params is part of the api..

But this will add an unneeded dependency to sale_stock module. Are you sure this is needed?

@pedrobaeza sorry for the noise. You are right. The filed packaging is not defined on the sale.order.line in this module. Strange to see a parameter for a field defined in an optional module...

…n demand sale order line prices ================================================== Recalculation of sale order lines prices on demand ================================================== This module adds a button on sale orders below pricelist that recalculates the prices of the order lines that contain a product in them. It is launched manually as a button to get the user decide if he/she wants to recalculate prices when pricelist is changed. Usage ===== Inside a sale order, you can click in any moment a button called "(Recalculate prices)", that is next to the pricelist selection, to launch a recalculation of all the prices of the lines, losing previous custom prices. Known issues / Roadmap ====================== * In a sale order with lot of lines, the recalculation may slow down, because sale general data (amount untaxed, amount taxed...) are recalculated for each line.

lmignon · 2015-08-29T07:05:35Z

👍

pedrobaeza · 2015-09-01T01:51:33Z

Please merge this old one that it's already completed.

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices

pedrobaeza added the work in progress label Nov 3, 2014

StefanRijnhart reviewed Jan 21, 2015
View reviewed changes

max3903 added this to the 8.0 milestone Feb 27, 2015

yvaucher reviewed Apr 24, 2015
View reviewed changes

pedrobaeza mentioned this pull request Aug 26, 2015

[ADD] sale_update_pricelist: #198

Closed

pedrobaeza force-pushed the 8.0-sale_order_recalculate_prices branch from 3a5e5e8 to 1ad0c1e Compare August 28, 2015 06:47

pedrobaeza added needs review and removed work in progress labels Aug 28, 2015

pedrobaeza force-pushed the 8.0-sale_order_recalculate_prices branch from 1ad0c1e to c801f40 Compare August 28, 2015 06:52

lmignon reviewed Aug 28, 2015
View reviewed changes

pedrobaeza changed the title ~~[ADD] sale_order_recalculate_prices: Module to allow to recalculate on demand sale order line prices~~ [ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices Aug 28, 2015

gurneyalex added the needs fixing label Aug 28, 2015

pedrobaeza force-pushed the 8.0-sale_order_recalculate_prices branch from c801f40 to 8046370 Compare August 28, 2015 10:38

lmignon reviewed Aug 28, 2015
View reviewed changes

pedrobaeza force-pushed the 8.0-sale_order_recalculate_prices branch from 8046370 to 03dbbd4 Compare August 28, 2015 16:37

pedrobaeza force-pushed the 8.0-sale_order_recalculate_prices branch from 03dbbd4 to 9081bd4 Compare August 28, 2015 16:38

yvaucher mentioned this pull request Aug 28, 2015

[REF] add link to AGPL licence; OCA/maintainer-tools#111

Merged

lmignon mentioned this pull request Aug 29, 2015

Images in module description not properly displayed on app.store and in the list of local modules in an odoo instance. OCA/maintainer-tools#112

Closed

pedrobaeza removed the needs fixing label Sep 1, 2015

gurneyalex added a commit that referenced this pull request Sep 1, 2015

Merge pull request #54 from pedrobaeza/8.0-sale_order_recalculate_prices

14a70cd

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices

gurneyalex merged commit 14a70cd into OCA:8.0 Sep 1, 2015

gurneyalex removed the needs review label Sep 1, 2015

pedrobaeza deleted the 8.0-sale_order_recalculate_prices branch September 15, 2015 15:02

pedrobaeza mentioned this pull request Sep 15, 2015

[8.0] Too many calculations on price_subtotal field on sale.order.line odoo/odoo#8537

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices #54

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices #54

pedrobaeza commented Oct 31, 2014

sbidoul commented Oct 31, 2014

pedrobaeza commented Oct 31, 2014

clonedagain commented Nov 1, 2014

rvalyi commented Nov 2, 2014

pedrobaeza commented Nov 2, 2014

vrenaville commented Nov 3, 2014

pedrobaeza commented Nov 3, 2014

clonedagain commented Nov 25, 2014

adrienpeiffer commented Nov 26, 2014

StefanRijnhart Jan 21, 2015

lmignon Jan 21, 2015

pedrobaeza Aug 28, 2015

StefanRijnhart commented Jan 21, 2015

pedrobaeza commented Jan 23, 2015

yvaucher Apr 24, 2015

StefanRijnhart commented Apr 24, 2015

pedrobaeza commented Aug 28, 2015

lmignon Aug 28, 2015

pedrobaeza Aug 28, 2015

yvaucher Aug 28, 2015

lmignon commented Aug 28, 2015

pedrobaeza commented Aug 28, 2015

pedrobaeza commented Aug 28, 2015

gurneyalex commented Aug 28, 2015

gurneyalex commented Aug 28, 2015

lmignon Aug 28, 2015

pedrobaeza Aug 28, 2015

lmignon Sep 1, 2015

lmignon commented Aug 29, 2015

pedrobaeza commented Sep 1, 2015

		@@ -0,0 +1,8 @@
		Recalculation of sale order lines prices on demand

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices #54

[ADD] sale_order_price_recalculation: Module to allow to recalculate on demand sale order line prices #54

Conversation

pedrobaeza commented Oct 31, 2014

Recalculation of sale order lines prices on demand

Usage

Known issues / Roadmap

sbidoul commented Oct 31, 2014

pedrobaeza commented Oct 31, 2014

clonedagain commented Nov 1, 2014

rvalyi commented Nov 2, 2014

pedrobaeza commented Nov 2, 2014

vrenaville commented Nov 3, 2014

pedrobaeza commented Nov 3, 2014

clonedagain commented Nov 25, 2014

adrienpeiffer commented Nov 26, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart commented Jan 21, 2015

pedrobaeza commented Jan 23, 2015

Choose a reason for hiding this comment

StefanRijnhart commented Apr 24, 2015

pedrobaeza commented Aug 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmignon commented Aug 28, 2015

pedrobaeza commented Aug 28, 2015

pedrobaeza commented Aug 28, 2015

gurneyalex commented Aug 28, 2015

gurneyalex commented Aug 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmignon commented Aug 29, 2015

pedrobaeza commented Sep 1, 2015