[REF] CONTRIBUTING.md: Add section for "don't bypass the ORM" #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| # very very wrong | ||
| cr.execute('select id from auction_lots where auction_id in (' + | ||
| ','.join(map(str, ids)) + ') and state=%s and obj_price>0', | ||
| ('draft',)) |
There was a problem hiding this comment.
Assuming ids to be a list of integers, how can injection be made here?
There was a problem hiding this comment.
If you don't have a constraint validating that the value must be a list of integer we are susceptible to sql injection with concatenate.
The sql injection is explain better here
There was a problem hiding this comment.
@eLBati
FYI I have created follow script to understand the real issue of sql injection:
https://github.com/vauxoo-dev/gist-vauxoo/blob/master/sql_injection.py
nhomar
added a commit
that referenced
this pull request
Mar 16, 2016
[REF] CONTRIBUTING.md: Add section for "don't bypass the ORM"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important section extracted from: odoo/coding_guidelines_framework