[MIG][9.0] template: Upgrade JS API #208
Conversation
|
Thanks for this update 👍 |
|
👍 Thanks @lasley |
|
@moylop260, there's a strange error in Travis. Do you have an idea of it? |
|
I saw the same error from stable branch build It is a traceback from flake8 I'll use travis2docker to debug and fix it.. |
|
FYI I can reproduce it with t2d using the travis original image (with other environment I can't reproduce it) The version with problem flake8 3.0.2 I install a old version 2.6.2 and work fine! I will create a new PR with a freeze of version |
|
|
||
| core.bus.on('web_client_ready', null, function () { | ||
| // Script that will be loaded when document is ready | ||
| }); |
There was a problem hiding this comment.
This approach doesn't work for website. Instead, the proper way to determine that the document is ready seems to be via ready() in web_editor.base, which returns a Promise object. This means that for website, the example here should look more like:
var base = require('web_editor.base');
base.ready().done(function() {
// Script that will be loaded when document is ready
});
There was a problem hiding this comment.
This is not used in website, but on web client (as stated). Maybe we should include both in 2 files: one for web, and another for website.
There was a problem hiding this comment.
I see no reason to not include as many examples as possible. @pedrobaeza you're thinking a separate file would be good instead of just putting both here and commenting the difference?
There was a problem hiding this comment.
Yes, I'm thinking about 2 files, naming then web_module_name.js and website_module_name.js
lasley
force-pushed
the
bugfix/9.0/js9-api
branch
from
c95f022
to
8429ead
Compare
|
Split website sample into separate file and added a web_ namespace to the web ones & rebased onto master to fix conflicts. I did not add a website tour file, because I am not quite sure of the intricacies between the back and front end tours (if any). IMO it would be bad for me to add a sample I am not 100% positive of 😄 |
|
👍 |
* Upgrade JS to new API * Upgrade onload method to use core bus web_client_ready * Add an exported method * Create website module and namespace web modules
lasley
force-pushed
the
bugfix/9.0/js9-api
branch
from
8429ead
to
1b81178
Compare
|
Squashed. This is good for merge? |
Milestone (Odoo version)
Module(s)
Fixes / new features
REF OCA/web#386 (comment)
cc @antespi @pedrobaeza