[ADD] template: PhantomJS Test Sample #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should have branches 8.0, 9.0 of MT to accommodate all of these changes to all versions. Can you please bring the topic to mailing list? About this, isn't needed a Python file to launch the test? |
|
@pedrobaeza you are correct that a Python file is also required - we already had that part in our template for some reason. Writing the email now |
yajo
requested changes
Nov 3, 2016
| odoo.define_section('module_name', ['module_name.ExportedObject'], function(test) { | ||
| "use strict"; | ||
|
|
||
| test('It should demonstrate a PhantomJS test', |
There was a problem hiding this comment.
Please specify that this is for backend tests.
| function(assert, ExportedObject) { | ||
| var expect = 'Expected Return', | ||
| result = new ExportedObject(); | ||
| assertStrictEqual( |
There was a problem hiding this comment.
this must be assert.assertStrictEqual, right?
* Change description to include that it is for web/backend * Fix assertion on no object
lasley
force-pushed
the
feature/9.0/add-phantom-example
branch
from
1ed89cf
to
19a5b41
Compare
|
Thanks @yajo - updated |
yajo
approved these changes
Nov 7, 2016
|
👍 |
pedrobaeza
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone (Odoo version)
Module(s)
Fixes / new features