Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create users in OCA instance for partners with a github login #47

Merged
merged 18 commits into from
Mar 20, 2015

Conversation

gurneyalex
Copy link
Member

No description provided.

@gurneyalex
Copy link
Member Author

This PR depends on #36 (and I actually rebased my branch on top of that one)

@StefanRijnhart @guewen your feedback is welcome

@gurneyalex
Copy link
Member Author

@StefanRijnhart fixed thanks.

ResGroups = client.ResGroups
grp_project_user = ResGroups.get('project.group_project_user')
members_with_gh = ResPartner.search([('x_github_login', '!=', False),
('user_ids', '=', False)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check with active_test=True in the context here, so that we don't try to recreate users which have been set to inactive for some reason?

@gurneyalex
Copy link
Member Author

@StefanRijnhart the current problem I have is with duplicate partners: one has a github login set, no email, no user, the other has no github login, generally an email and a user. Manually adding the email fails (there's a unique key on email) and creating the partner fails too (duplicate login).

<rant>The partner model with its relations to users (and employees) is a total 💩</rant>

@jgrandguillaume
Copy link
Member

Need to use the dedupplicate contact in OCA Odoo instance for this issue

@gurneyalex
Copy link
Member Author

@jgrandguillaume can you help here with your deduplicate tool?

erppeek can browse on ids or domain...
@jgrandguillaume
Copy link
Member

👍

@gurneyalex
Copy link
Member Author

@StefanRijnhart ok, we made a quick session today with joel to fix the remaining database problems. This script has run, and we should be able to merge and move on with #36

@StefanRijnhart
Copy link
Member

Great, thanks. Tested but without actually creating users as per my privileges in the OCA database.\

👍

@guewen
Copy link
Member

guewen commented Mar 20, 2015

👍

guewen added a commit that referenced this pull request Mar 20, 2015
Create users in OCA instance for partners with a github login
@guewen guewen merged commit 0925996 into OCA:master Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants