Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] [MIG] maintenance_plan #15

Merged
merged 6 commits into from
Jul 19, 2019
Merged

[12.0] [MIG] maintenance_plan #15

merged 6 commits into from
Jul 19, 2019

Conversation

dalonsod
Copy link
Contributor

@dalonsod dalonsod commented Jul 8, 2019 •
edited
Loading

astirpe
astirpe requested changes Jul 8, 2019
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you can increase the tests coverage

maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 8, 2019

Would be nice if you can increase the tests coverage

@astirpe added some new test stuff

astirpe
astirpe requested changes Jul 9, 2019
View reviewed changes
maintenance_plan/views/maintenance.xml Outdated Show resolved Hide resolved
maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
maintenance_plan/models/maintenance.py Outdated Show resolved Hide resolved
@dalonsod
Copy link
Contributor Author

dalonsod commented Jul 9, 2019

Fixed README branch

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-15-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d8a6b57 into OCA:12.0 Jul 19, 2019
OCA-git-bot added a commit that referenced this pull request Jul 19, 2019
@OCA-git-bot
Merge PR #15 into 12.0
24bd09b 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 24bd09b. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 19, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astirpe astirpe astirpe approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dalonsod @OCA-git-bot @pedrobaeza @astirpe @AdriaGForgeFlow @grindtildeath @bestmazzo