Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] maintenance_equipment_sequence #174

Merged
merged 16 commits into from
Nov 2, 2021
Merged

[15.0][MIG] maintenance_equipment_sequence #174

merged 16 commits into from
Nov 2, 2021

Conversation

BernatPForgeFlow
Copy link
Member

No description provided.

AdriaGForgeFlow and others added 15 commits October 22, 2021 11:10
@AdriaGForgeFlow @BernatPForgeFlow
[11.0][ADD] maintenance_equipment_sequence
4895ddc
@JordiBForgeFlow @BernatPForgeFlow
fix sequence step
22c6c67
@LoisRForgeFlow @BernatPForgeFlow
Code always displayed as "Code" to avoid confusion and add it to sear…
f27e40b 
…ch view
@AdriaGForgeFlow @BernatPForgeFlow
fixup and increase test coverage
e44f565
@BernatPForgeFlow
Added translation using Weblate (Spanish)
6654945
@BernatPForgeFlow
Translated using Weblate (Spanish)
e0b3cca 
Currently translated at 100.0% (10 of 10 strings)

Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_sequence
Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_sequence/es/
@NuriaXifre @BernatPForgeFlow
[12.0][MIG]maintenance_equipment_sequence
00d1c7b
@etobella @BernatPForgeFlow
[FIX] maintenance_equipment_sequence write
66f68ee
@NuriaXifre @BernatPForgeFlow
[IMP] maintenance_equipment_sequence: black, isort
9e5e0e8
@NuriaXifre @BernatPForgeFlow
[13.0][MIG] maintenance_equipment_sequence
1bf90f6
@mymage @BernatPForgeFlow
Added translation using Weblate (Italian)
95fed0b
@mymage @BernatPForgeFlow
Translated using Weblate (Italian)
50e8100 
Currently translated at 100.0% (10 of 10 strings)

Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_sequence
Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_sequence/it/
@mariadforgeflow @BernatPForgeFlow
[IMP] maintenance_equipment_sequence: black, isort, prettier
8589328
@mariadforgeflow @BernatPForgeFlow
[MIG] maintenance_equipment_sequence: Migration to 14.0
0992d75
@BernatPForgeFlow
[IMP] maintenance_equipment_sequence: black, isort, prettier
53d29db
@BernatPForgeFlow
Copy link
Member Author

BernatPForgeFlow commented Oct 22, 2021 •
edited
Loading

@ForgeFlow
@LoisRForgeFlow
@AaronHForgeFlow

@BernatPForgeFlow BernatPForgeFlow force-pushed the 15.0-mig-maintenance_equipment_sequence branch from 3f1265d to b0ab5d2 Compare October 25, 2021 13:00
@dalonsod
Copy link
Contributor

@etobella maybe it's time to resume #159 , what do you think?

@BernatPForgeFlow BernatPForgeFlow force-pushed the 15.0-mig-maintenance_equipment_sequence branch from b0ab5d2 to f781f09 Compare October 27, 2021 15:02
@BernatPForgeFlow BernatPForgeFlow force-pushed the 15.0-mig-maintenance_equipment_sequence branch from f781f09 to 9e37e98 Compare October 28, 2021 09:22
etobella
etobella reviewed Oct 28, 2021
View reviewed changes
maintenance_equipment_sequence/migrations/15.0.1.0.0/pre-migration.py Outdated Show resolved Hide resolved
maintenance_equipment_sequence/migrations/15.0.1.0.0/pre-migration.py

if not version:
return

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to create two new legacy columns with the old values (code and serial_no). This way if an implementation worked with serials but wanted to change the code to serial no by default and move the old serial no to a new field , they can execute a script later. Would be great to have an example of this SQL script on the comment of the migration.

In order to be able to pass this changes to older versions. Check if the code column exists. In this case, the migration has already been done.

etobella
etobella reviewed Oct 28, 2021
View reviewed changes
maintenance_equipment_sequence/views/maintenance_views.xml
<field name="name">equipment.form</field>
<field name="model">maintenance.equipment</field>
<field name="inherit_id" ref="maintenance.hr_equipment_view_form" />
<field name="arch" type="xml">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a 99 priority, as other modules could have problem with the duplication of the field.

Also make the original serial_no invisible

maintenance_equipment_sequence/views/maintenance_views.xml Outdated Show resolved Hide resolved
@BernatPForgeFlow BernatPForgeFlow force-pushed the 15.0-mig-maintenance_equipment_sequence branch 2 times, most recently from 89e5653 to aacc1d3 Compare October 29, 2021 09:32
AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review (including migration scripts) 👍

@BernatPForgeFlow BernatPForgeFlow force-pushed the 15.0-mig-maintenance_equipment_sequence branch from aacc1d3 to 151c2b4 Compare October 29, 2021 09:57
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

etobella commented Nov 2, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-174-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ceb049d into OCA:15.0 Nov 2, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 92c71f6. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-maintenance_equipment_sequence branch November 2, 2021 08:45
@pedrobaeza
Copy link
Member

/ocabot migration maintenance_equipment_sequence

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 9, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 9, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet