Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] maintenance_stock: Migration to 13.0 #337

Merged
merged 12 commits into from
Jul 7, 2023
Merged

[13.0][MIG] maintenance_stock: Migration to 13.0 #337

merged 12 commits into from
Jul 7, 2023

Conversation

mamcode
Copy link
Member

@mamcode mamcode commented Jun 3, 2023

No description provided.

dalonsod and others added 11 commits June 3, 2023 18:16
@dalonsod @mamcode
[ADD] maintenance_stock
58d2059
@oca-travis @mamcode
[UPD] Update maintenance_stock.pot
0ef234c
@OCA-git-bot @mamcode
[ADD] icon.png
34b9a05
@dalonsod @mamcode
Added translation using Weblate (Spanish)
8b8e0bb
@dalonsod @mamcode
Translated using Weblate (Spanish)
249b687 
Currently translated at 96.7% (29 of 30 strings)

Translation: maintenance-12.0/maintenance-12.0-maintenance_stock
Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/es/
@marcelsavegnago @mamcode
Added translation using Weblate (Portuguese (Brazil))
618de51
@marcelsavegnago @mamcode
Translated using Weblate (Portuguese (Brazil))
976bdfd 
Currently translated at 100.0% (30 of 30 strings)

Translation: maintenance-12.0/maintenance-12.0-maintenance_stock
Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/pt_BR/
@mymage @mamcode
Added translation using Weblate (Italian)
90e049f
@mymage @mamcode
Translated using Weblate (Italian)
a6b1f91 
Currently translated at 100.0% (30 of 30 strings)

Translation: maintenance-12.0/maintenance-12.0-maintenance_stock
Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/
@francesco-ooops @mamcode
Translated using Weblate (Italian)
797cfd9 
Currently translated at 100.0% (30 of 30 strings)

Translation: maintenance-12.0/maintenance-12.0-maintenance_stock
Translate-URL: https://translation.odoo-community.org/projects/maintenance-12-0/maintenance-12-0-maintenance_stock/it/
@mamcode
[IMP] maintenance_stock: pre-commit execution
61de0a0
@mamcode mamcode force-pushed the 13.0-mig-maintenance_stock branch 3 times, most recently from c44f8c4 to 19e624d Compare June 4, 2023 00:02
@mamcode
Copy link
Member Author

mamcode commented Jun 4, 2023

@dalonsod Please can you help me with a review ?

@mamcode
Copy link
Member Author

mamcode commented Jun 4, 2023

@rhe-mastercore maybe you can help with a review here :)

@mamcode mamcode changed the title [13.0][MIG] maintenance_stock [13.0][MIG] maintenance_stock: Migration to 13.0 Jun 4, 2023
dalonsod
dalonsod suggested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Only code review

maintenance_stock/models/stock_warehouse.py Outdated
Comment on lines 69 to 71
def _get_locations_values(self, vals, code=False):
sub_locations = super()._get_locations_values(vals)
code = vals.get("code") or self.code
Copy link
Contributor

@dalonsod dalonsod Jul 2, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but with new _get_locations_values definition, should this code be like this (not tested)?

Suggested change
def _get_locations_values(self, vals, code=False):
sub_locations = super()._get_locations_values(vals)
code = vals.get("code") or self.code
def _get_locations_values(self, vals, code=False):
sub_locations = super()._get_locations_values(vals, code=code)
code = vals.get("code") or code or self.code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right

@mamcode mamcode force-pushed the 13.0-mig-maintenance_stock branch from 19e624d to 4e3b7b0 Compare July 5, 2023 15:34
@mamcode
Copy link
Member Author

mamcode commented Jul 5, 2023

The Job pre-commit is falling but I don't know how to resolve it.
It seems to have nothing to do with the code of this PR
@dalonsod Can you help me ?

@dalonsod
Copy link
Contributor

dalonsod commented Jul 6, 2023

I'm sorry, I don't know why that error is raised. Anyway, it could be only a temporary issue, could you update PR with a dummy commit, so github actions should be fired again and check if error persists?

@dalonsod dalonsod mentioned this pull request Jul 6, 2023
Open
@mamcode mamcode force-pushed the 13.0-mig-maintenance_stock branch from 4e3b7b0 to 41b6232 Compare July 6, 2023 11:46
@mamcode
Copy link
Member Author

mamcode commented Jul 6, 2023

@dalonsod Review again please.

dalonsod
dalonsod approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍 using existing and new warehouses.

etobella
etobella approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-337-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ded5b2b into OCA:13.0 Jul 7, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7fdb7cb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mamcode @dalonsod @OCA-git-bot @etobella @oca-travis @marcelsavegnago @mymage @francesco-ooops