9.0 mgmtsystem nonconformity #140

naousse · 2016-06-09T17:42:13Z

No description provided.

coveralls · 2016-06-09T18:39:11Z

Coverage remained the same at 100.0% when pulling ddf5be1 on naousse:9.0-mgmtsystem_nonconformity into 18b9b4c on OCA:9.0.

naousse · 2016-06-09T19:14:25Z

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py

@@ -218,27 +227,71 @@ def create(self, vals):

    @api.multi
    def message_auto_subscribe(self, updated_fields, values=None):


@dreispt
Please Daniel, i need your help here. I'm unable to register a nonconformity because of this method that doesn't work.

dreispt · 2016-06-27T08:33:43Z

mgmtsystem_nonconformity/models/mgmtsystem_nonconformity.py

@@ -120,7 +138,7 @@ def _state_name(self):
        track_visibility='onchange',
    )
    state_name = fields.Char(


I don't think this fieds is needed. State alone is enough.

max3903 · 2016-06-29T12:57:58Z

@naousse You can rebase this branch now.

max3903 · 2016-07-01T13:34:33Z

@naousse

The create button has disappeared when you click on nonconformity in the menu
Drag and drop in the kanban view is not working
Merge [IMP] README.rst naousse/management-system#7 to improve README file
The "Close" button has disappeared. I had to click on "Closed" in the workflow steps to close the NC
Check the form view on branch 8.0, I think the action plan comments and effectiveness review fields have been improved

dreispt · 2016-07-27T08:09:51Z

@max3903 I didn't get this one:

When the NC is in progress state/stage, the actions of the plan should be opened.

dreispt · 2016-07-27T09:06:50Z

@naousse naousse#11 implements it and a few other improvements/fixes - check the commit messages

Naousse 9.0 mgmtsystem nonconformity

max3903 · 2016-07-27T14:06:02Z

I was able to move the NC to the In Progress state/stage without the plan review. I should get an error message and be asked to enter it.
In the chatter of a nonconformity, the state/stage changes appears twice in each message
When the NC is in progress state/stage, the actions of the plan should be opened.
The menu item for report is not consistent with the others: Nonconformity --> Nonconformities

See http://3151194-140-e585e9.runbot2.odoo-community.org/web#id=2&view_type=form&model=mgmtsystem.nonconformity&menu_id=131&action=120

dreispt · 2016-07-27T14:49:51Z

When the NC is in progress state/stage, the actions of the plan should be opened.

I don't understand this.

max3903 · 2016-07-27T14:59:19Z

@dreispt Actions are in draft until the action plan is reviewed. Once done, actions are opened and assignees can start working on them.

…ress

dreispt · 2016-07-28T10:28:21Z

There you go: naousse#12 should fix those issues.
During tests, I figured that the "Pending Approval" stage wasn't intuitive, so I renamed it to "Action Plan".

Naousse 9.0 mgmtsystem nonconformity

max3903 · 2016-07-28T17:48:42Z

I was able to close the NC with one action opened. I should get an error message and be asked to close every actions first (the immediate action and the ones of the action plan).

Otherwise 👍

dreispt · 2016-07-28T21:20:56Z

There you go naousse#13

Don't close an NC with open Actions

dreispt · 2016-07-29T07:28:24Z

Coverage back to 100% 😺

max3903 · 2016-07-29T14:25:28Z

👍 Good work guys!

dreispt · 2016-07-29T15:37:25Z

🏆

max3903 added the needs fixing label Jun 9, 2016

max3903 added this to the 9.0 milestone Jun 9, 2016

naousse reviewed Jun 9, 2016
View reviewed changes

pedrobaeza mentioned this pull request Jun 24, 2016

Migration to version 9.0 #92

Closed

30 tasks

dreispt reviewed Jun 27, 2016
View reviewed changes

mgmtsystem_nonconformity progress

c03f57f

naousse force-pushed the 9.0-mgmtsystem_nonconformity branch from bbb5a1f to c03f57f Compare June 30, 2016 14:34

naousse added 11 commits June 30, 2016 11:10

Improving test

0dd5fe5

Improving test coverage

5802a7e

Fixing flake8 error

d37b23b

Improve code coverage continuation

46b36cd

Improve continue

7a71782

Fixing flake 8 error

58ddf7a

Fixing test error

719c0ba

Fixing new test error

f4fa66b

fixing test error

47b1fa0

More test added

d26311e

Remove unnecessary code

c481fba

max3903 self-assigned this Jul 1, 2016

[IMP] README.rst

0012158

Replace age by days since last update

873c415

dreispt added 3 commits July 27, 2016 09:16

Fix reports

e3d08f1

Reset Kanban State when changing Stages

501e081

Prefer using the standard user_id field

ca08581

dreispt added 2 commits July 27, 2016 10:11

Properly implement the NC closing date

b6db8fb

Fix report security

6de533c

dreispt added needs review and removed needs fixing labels Jul 27, 2016

Merge pull request #11 from dreispt/naousse-9.0-mgmtsystem_nonconformity

e585e96

Naousse 9.0 mgmtsystem nonconformity

dreispt and others added 2 commits July 28, 2016 11:20

Require action plan review for In Progress; Open Actions when In Prog…

1316de2

…ress

Rename Pending Approval to Action Plan

6e8d280

naousse added 3 commits July 28, 2016 12:38

Merge pull request #12 from dreispt/naousse-9.0-mgmtsystem_nonconformity

8a4468d

Naousse 9.0 mgmtsystem nonconformity

Removing pylint and flake8 error using comment

01307f8

import translator _

748081e

dreispt and others added 4 commits July 28, 2016 22:26

Don't close an NC with open Actions

f9a5baf

Add tests to group by stage

d350621

Add tests for Kanban state reset on stage change

6e608e4

Merge pull request #13 from dreispt/naousse-9.0-mgmtsystem_nonconformity

d0f5422

Don't close an NC with open Actions

max3903 merged commit 9780744 into OCA:9.0 Jul 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

9.0 mgmtsystem nonconformity #140

9.0 mgmtsystem nonconformity #140

naousse commented Jun 9, 2016

coveralls commented Jun 9, 2016 •

edited

Loading

naousse Jun 9, 2016

dreispt Jun 27, 2016

max3903 commented Jun 29, 2016

max3903 commented Jul 1, 2016 •

edited

Loading

dreispt commented Jul 27, 2016

dreispt commented Jul 27, 2016

max3903 commented Jul 27, 2016 •

edited

Loading

dreispt commented Jul 27, 2016

max3903 commented Jul 27, 2016

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016 •

edited

Loading

dreispt commented Jul 28, 2016

dreispt commented Jul 29, 2016

max3903 commented Jul 29, 2016

dreispt commented Jul 29, 2016

		@@ -218,27 +227,71 @@ def create(self, vals):

		@api.multi
		def message_auto_subscribe(self, updated_fields, values=None):

9.0 mgmtsystem nonconformity #140

9.0 mgmtsystem nonconformity #140

Conversation

naousse commented Jun 9, 2016

coveralls commented Jun 9, 2016 • edited Loading

naousse Jun 9, 2016

Choose a reason for hiding this comment

dreispt Jun 27, 2016

Choose a reason for hiding this comment

max3903 commented Jun 29, 2016

max3903 commented Jul 1, 2016 • edited Loading

dreispt commented Jul 27, 2016

dreispt commented Jul 27, 2016

max3903 commented Jul 27, 2016 • edited Loading

dreispt commented Jul 27, 2016

max3903 commented Jul 27, 2016

dreispt commented Jul 28, 2016

max3903 commented Jul 28, 2016 • edited Loading

dreispt commented Jul 28, 2016

dreispt commented Jul 29, 2016

max3903 commented Jul 29, 2016

dreispt commented Jul 29, 2016

coveralls commented Jun 9, 2016 •

edited

Loading

max3903 commented Jul 1, 2016 •

edited

Loading

max3903 commented Jul 27, 2016 •

edited

Loading

max3903 commented Jul 28, 2016 •

edited

Loading