9.0 mgmtsystem severity #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max3903
requested changes
Sep 26, 2016
|
|
||
| * Clone the project from github on your instance | ||
| * git clone https://github.com/OCA/management-system.git | ||
| * Start odoo with the project in the addons path |
There was a problem hiding this comment.
- No need for installation instructions.
| To use this module, you need to: | ||
|
|
||
| * go to Management System > Configuration > Severity | ||
|
|
There was a problem hiding this comment.
- Please add the
Try me on Runbotlink
| Contributors | ||
| ------------ | ||
|
|
||
| * Loïc Faure-Lacroix <loic.lacroix@savoirfairelinux.com> |
dreispt
requested changes
Oct 23, 2016
| "website": "http://www.savoirfairelinux.com", | ||
| "license": "AGPL-3", | ||
| "category": "Management System", | ||
| "complexity": "normal", |
| @@ -0,0 +1,27 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Missing copyright notice (please use short headers)
|
|
||
|
|
||
| class MgmtSystemSeverity(models.Model): | ||
|
|
|
|
||
| value = fields.Integer("Value", required=True) | ||
|
|
||
| category = fields.Selection(( |
There was a problem hiding this comment.
Selection values usually is a List of tuples, rather than a Tuple of tuples.
|
|
||
| checks = [ | ||
| test_create_severity | ||
| ] |
There was a problem hiding this comment.
AFAIK the checksvariable is not needed (?)
max3903
requested changes
Oct 24, 2016
| "website": "http://www.savoirfairelinux.com", | ||
| "license": "AGPL-3", | ||
| "category": "Management System", | ||
| "complexity": "normal", |
There was a problem hiding this comment.
@naousse Keep the website, license and category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.