[MIG] port mgmtsystem hazard to V9 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max3903
requested changes
Feb 3, 2017
| ------------ | ||
|
|
||
| * Maxime Chambreuil <maxime.chambreuil@savoirfairelinux.com> | ||
| * Loïc Lacroix <loic.lacroix@savoirfairelinux.com> |
There was a problem hiding this comment.
@ngrandjean Please add yourself to the list.
mgmtsystem_hazard/__openerp__.py
Outdated
| "version": "1.1", | ||
| "author": "Savoir-faire Linux,Odoo Community Association (OCA)", | ||
| "name": "Hazard", | ||
| "version": "9.0.1.1.0", |
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## |
There was a problem hiding this comment.
Please use the shorter version of the header:
# -*- coding: utf-8 -*-
# Copyright <YEAR(S)> <AUTHOR(S)>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
|
Hey @ngrandjean, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
max3903
approved these changes
Feb 6, 2017
dreispt
requested changes
Mar 6, 2017
| company_id = fields.Many2one( | ||
| 'res.company', | ||
| 'Company', | ||
| default=lambda s: s.env['res.users'].browse(s._uid).company_id, |
There was a problem hiding this comment.
I think this can be just s.env.user.company_id.
Can you check that?
| _name = "mgmtsystem.hazard.origin" | ||
| _description = "Origin of hazard" | ||
|
|
||
| name = fields.Char('Origin', size=50, required=True, translate=True) |
| _name = "mgmtsystem.hazard.probability" | ||
| _description = "Probability of hazard" | ||
|
|
||
| name = fields.Char('Probability', size=50, required=True, translate=True) |
| _name = "mgmtsystem.hazard.severity" | ||
| _description = "Severity of hazard" | ||
|
|
||
| name = fields.Char('Severity', size=50, required=True, translate=True) |
| _name = "mgmtsystem.hazard.test" | ||
| _description = "Implementation Tests of hazard" | ||
|
|
||
| name = fields.Char('Test', size=50, required=True, translate=True) |
| _description = "Usage of hazard" | ||
| name = fields.Char( | ||
| 'Occupation / Usage', | ||
| size=50, |
dreispt
approved these changes
Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from v8.0 to 9.0
Align files to most recent version of branch 8.0 (code version of branch to migrate was quite old)
Change indicated version to 9.0
Replace by in xml files and remove
Make module installable