Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mig document page work instructions to v. 10.0 #176

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Mig document page work instructions to v. 10.0 #176

merged 1 commit into from
Mar 30, 2017

Conversation

eugen-don
Copy link
Member

@eugen-don eugen-don commented Mar 14, 2017 •
edited
Loading

Mig document page work instructions to v. 10.0

Depends on:

@max3903 max3903 modified the milestone: 10.0 Mar 18, 2017
@pedrobaeza pedrobaeza mentioned this pull request Mar 18, 2017
Closed
31 tasks
@eugen-don eugen-don mentioned this pull request Mar 21, 2017
Merged
1 task
@dreispt
Copy link
Sponsor Member

dreispt commented Mar 21, 2017

@eugen-don Can you please help reviewing OCA/knowledge#122 ?

dreispt
dreispt requested changes Mar 21, 2017
View reviewed changes
Copy link
Sponsor Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that something went wrong when porting the change history from 9.0 to 10.0.

document_page_procedure/__manifest__.py Outdated
@@ -20,20 +20,22 @@
##############################################################################
{
"name": "Document Management - Wiki - Procedures",
"version": "9.0.1.0.0",
"version": "10.0.0",
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.0.1.0.0

document_page_procedure/__manifest__.py Outdated
"author": "Savoir-faire Linux,Odoo Community Association (OCA)",
"website": "http://www.savoirfairelinux.com",
"license": "AGPL-3",
"category": "Generic Modules/Others",
"description": """Procedure Template
""",
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove description key - we have the README for that.

document_page_procedure/__manifest__.py Outdated
"depends": [
'document_page_work_instruction'
'document_page_work_instructions'
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... module names are supposed to be singular, not plural.
Are you sure about this change?

document_page_quality_manual/README.rst Outdated
Quality Manual
==============

This module provides a quality manual template. The template has the same structure as the ISO 9001 standard.
This module was written to provide a quality manual template. The template has the same structure as the ISO 9001 standard.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the original form is better: we describe what the module does, not how it was done.

document_page_quality_manual/README.rst Outdated

.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/118/9.0
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the Runbot link?

document_page_quality_manual/README.rst Outdated
@@ -42,7 +32,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/management-system/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback
`here <https://github.com/OCA/management-system/issues/new?body=module:%20document_page_quality_manual%0Aversion:%209.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`here <https://github.com/OCA/management-system/issues/new?body=module:%20document_page_quality_manual%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0?

@eugen-don eugen-don changed the title Mig document page work instructions to v. 10.0 WIP Mig document page work instructions to v. 10.0 Mar 23, 2017
@eugen-don eugen-don force-pushed the MIG-document_page_work_instructions-to-V.-10.0 branch from 7d02d8a to fc8b114 Compare March 25, 2017 15:01
@eugen-don eugen-don changed the title WIP Mig document page work instructions to v. 10.0 Mig document page work instructions to v. 10.0 Mar 26, 2017
@eugen-don
Copy link
Member Author

Hi @dreispt
I rebased the pull on latest V 9.0, but im still not familiar with the git magic you mentioned. Is there any template README file i could use?

@eugen-don eugen-don force-pushed the MIG-document_page_work_instructions-to-V.-10.0 branch 2 times, most recently from f784a58 to 32b7aa8 Compare March 27, 2017 19:49
@grindtildeath
Copy link

@eugen-don
Here are the OCA guidelines in case that's what you were looking for :
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0
Other wise looks good to me. 👍

max3903
max3903 requested changes Mar 28, 2017
View reviewed changes
Copy link
Sponsor Member

@max3903 max3903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugen-don In the README.rst, the link to Runbot and Github issues still points or uses version 9.0

@eugen-don
MIG document_page_work_instructions to V. 10.0
a213856 
MIG document_page_work_instructions to V. 10.0
@eugen-don eugen-don force-pushed the MIG-document_page_work_instructions-to-V.-10.0 branch from 32b7aa8 to a213856 Compare March 29, 2017 09:47
@eugen-don
Copy link
Member Author

@grindtildeath
Thanks for providing the resource.

@max3903
Copy link
Sponsor Member

max3903 commented Mar 29, 2017

@dreispt Can you update your review please?

@dreispt dreispt merged commit 540f3df into OCA:10.0 Mar 30, 2017
@eugen-don eugen-don deleted the MIG-document_page_work_instructions-to-V.-10.0 branch April 1, 2017 03:34
@eugen-don eugen-don restored the MIG-document_page_work_instructions-to-V.-10.0 branch April 3, 2017 11:06
@eugen-don eugen-don deleted the MIG-document_page_work_instructions-to-V.-10.0 branch April 18, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@max3903 max3903 max3903 approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eugen-don @dreispt @grindtildeath @max3903 @sbidoul