Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] mgmtsystem survey #218

Merged
merged 35 commits into from Sep 28, 2018

Conversation

jalzaga
Copy link
Contributor

@jalzaga jalzaga commented Apr 15, 2018

Module mgmtsystem_survey Migration to version 11.0 #200

@pedrobaeza pedrobaeza mentioned this pull request Apr 16, 2018
30 tasks
@etobella
Copy link
Member

etobella commented Jul 6, 2018

@jalzaga Can you rebase it in order to review it?

@max3903 max3903 added this to the 11.0 milestone Jul 9, 2018
@max3903
Copy link
Sponsor Member

max3903 commented Jul 9, 2018

@jalzaga I don't know what you did, but it didn't work as expected. This pull request now includes mgmtsystem and it should not.

Try to rebase using:

git remote add oca git@github.com:OCA/management-system.git
git fetch oca
git rebase -i oca/11.0

@aselcis
Copy link

aselcis commented Jul 9, 2018

@max3903 First of all, thank you for your guide lines.
This is exactly what I did.
When I did the "git rebase -i oca/11.0" it added the mgmtsystem module in my local directory,
Then it asked me to use git pull to merge the remote branch into mine.
The last step it asked me was a git push to publish the local commits
Please, let me know what is wrong.

@max3903
Copy link
Sponsor Member

max3903 commented Jul 9, 2018

@jalzaga You should not pull to merge. You should force the push:

git remote add oca git@github.com:OCA/management-system.git
git fetch oca
git rebase -i oca/11.0
git push -f origin 11.0-mig-mgmtsystem_survey

I am assuming that origin is git@github.com:Aselcis-Consulting/management-system.git

@aselcis
Copy link

aselcis commented Jul 9, 2018

Thank you @max3903
However it was the "git rebase -i oca/11.0" command what added the mgmtsystem module to my local directory because it was merged recently. The git push -f will add it to the remote git@github.com:Aselcis-Consulting/management-system.git
Anyway , what should I do?

@max3903
Copy link
Sponsor Member

max3903 commented Jul 9, 2018

@jalzaga Revert your merge commit (last commit on your branch) and push with -f

git reset --hard HEAD^
git push -f origin 11.0-mig-mgmtsystem_survey

@aselcis aselcis force-pushed the 11.0-mig-mgmtsystem_survey branch from bbdd68a to 5bed07c Compare July 9, 2018 19:55
@jalzaga
Copy link
Contributor Author

jalzaga commented Sep 28, 2018

This PR is ready to be tested

@max3903 max3903 merged commit 05f811c into OCA:11.0 Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet