[11.0][IMP] mrp_flattened_bom_xlsx: cover multi level bom case #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HviorForgeFlow
suggested changes
Oct 19, 2018
There was a problem hiding this comment.
@lreficent It would be convenient to settle how we use product quantity related to top parent.
For example if I change from 1 -> 10 below:
I receive that result:
I think just forcing top product quantity to 1 in report is fine.
BTW I appreciate the face wash. Thanks 😄
|
@hveficent I made explicit that the bom method computes the unit requirements in the default UoM. |
JordiBForgeFlow
approved these changes
Nov 2, 2018
HviorForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
May 28, 2019
Merged
AdriaGForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
Jan 9, 2020
AdriaGForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
Jan 15, 2020
BernatPForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
Nov 11, 2021
JoanMForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
Dec 9, 2021
dsolanki-initos
pushed a commit
to initOS/manufacture-reporting
that referenced
this pull request
May 30, 2023
AndreuOForgeFlow
pushed a commit
to ForgeFlow/manufacture-reporting
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the computation on multi level BoMs was not correct. Added tests.
cc @hveficent @jbeficent