Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][IMP] mrp_bom_current_stock : Add XLSX report #52

Merged
merged 2 commits into from
Feb 18, 2019
Merged

[11.0][IMP] mrp_bom_current_stock : Add XLSX report #52

merged 2 commits into from
Feb 18, 2019

Conversation

HviorForgeFlow
Copy link
Member

  • Add posibility to export to XLSX report.
  • Now depends on report_xlsx module

CC @ageficent @mreficent @lreficent @jbeficent

@HviorForgeFlow
Copy link
Member Author

WIP: Test are needed to ensure location filtering is working correctly.

AdriaGForgeFlow
AdriaGForgeFlow approved these changes Feb 13, 2019
View reviewed changes
Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test and code review. LGTM 👍 (check travis)

@HviorForgeFlow HviorForgeFlow force-pushed the 11.0-add_xlsx-mrp_bom_current_stock branch 2 times, most recently from 1d88da3 to 511f324 Compare February 13, 2019 11:36
MiquelRForgeFlow
MiquelRForgeFlow approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review) 👍

LoisRForgeFlow
LoisRForgeFlow reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, some comments

mrp_bom_current_stock/wizard/bom_route_current_stock.py Outdated Show resolved Hide resolved
mrp_bom_current_stock/reports/report_mrpcurrentstock_xlsx.py Outdated Show resolved Hide resolved
@HviorForgeFlow
[11.0][IMP] mrp_bom_current_stock:
b76c7fa 
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
@HviorForgeFlow HviorForgeFlow force-pushed the 11.0-add_xlsx-mrp_bom_current_stock branch from a920122 to b76c7fa Compare February 15, 2019 13:03
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

LoisRForgeFlow
LoisRForgeFlow reviewed Feb 18, 2019
View reviewed changes
mrp_bom_current_stock/reports/report_mrpcurrentstock.xml Outdated
<tr>
<th>Level</th>
<th>Product</th>
<th>Quantity</th>
<th>Location</th>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be back in the pdf report

@HviorForgeFlow HviorForgeFlow force-pushed the 11.0-add_xlsx-mrp_bom_current_stock branch from 0786f29 to 8918d43 Compare February 18, 2019 11:40
LoisRForgeFlow
LoisRForgeFlow approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great now!

@LoisRForgeFlow LoisRForgeFlow merged commit b628151 into OCA:11.0 Feb 18, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-add_xlsx-mrp_bom_current_stock branch February 18, 2019 16:41
HviorForgeFlow added a commit to ForgeFlow/manufacture-reporting that referenced this pull request Feb 19, 2019
@HviorForgeFlow
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
2d5ed93 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
HviorForgeFlow added a commit to ForgeFlow/manufacture-reporting that referenced this pull request May 29, 2019
@HviorForgeFlow
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
bc68254 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
JoanSForgeFlow pushed a commit to ForgeFlow/manufacture-reporting that referenced this pull request Mar 3, 2020
@HviorForgeFlow @JoanSForgeFlow
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
f9b630d 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
BernatPForgeFlow pushed a commit to ForgeFlow/manufacture-reporting that referenced this pull request Dec 16, 2021
@HviorForgeFlow @BernatPForgeFlow
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
44db1b9 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
BernatPForgeFlow pushed a commit to ForgeFlow/manufacture-reporting that referenced this pull request Jan 10, 2022
@HviorForgeFlow @BernatPForgeFlow
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
ab9af19 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
dsolanki-initos pushed a commit to initOS/manufacture-reporting that referenced this pull request May 8, 2023
@HviorForgeFlow @dsolanki-initos
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
c80e634 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
dsolanki-initos pushed a commit to initOS/manufacture-reporting that referenced this pull request May 30, 2023
@HviorForgeFlow @aiendry-aktivsoftware
[11.0][IMP] mrp_bom_current_stock : Add XLSX report (OCA#52)
1cf5748 
* [11.0][IMP] mrp_bom_current_stock:
* Add xlsx report
* Fix location_id filter
* Improve wizard usability: it is possible to modify locations, qty available is recomputed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HviorForgeFlow @OCA-git-bot @LoisRForgeFlow @MiquelRForgeFlow @AdriaGForgeFlow