Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][ADD] mrp_bom_structure_report #54

Merged
merged 2 commits into from
Mar 28, 2019
Merged

[11.0][ADD] mrp_bom_structure_report #54

merged 2 commits into from
Mar 28, 2019

Conversation

AdriaGForgeFlow
Copy link

This is a back port from mrp structure report incorpored by Odoo in v12.0

The module includes three different kind of reports:

  1. BoM Structure & Cost Report
  2. BoM Structure Report
  3. BoM Cost Report

@AdriaGForgeFlow AdriaGForgeFlow force-pushed the 11.0-add-mrp_bom_structure_report branch 7 times, most recently from e0fc922 to 0976a84 Compare February 22, 2019 12:20
HviorForgeFlow
HviorForgeFlow suggested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review:

  • Print Unfolded is not taking into account quantities.

Nitpicking:

  • Use capital letter at the beginning of any word in print buttons.

@AdriaGForgeFlow
Copy link
Author

Functional review:

  • Print Unfolded is not taking into account quantities.

Nitpicking:

  • Use capital letter at the beginning of any word in print buttons.

In v12.0, in Odoo, Print unfolded has the same behaviour. Maybe this should be an improvement to be done since it make sense to print the same amount than the one that has been introduced by the user in the UI.

marcelofrare
marcelofrare approved these changes Mar 16, 2019
View reviewed changes
Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local installation. Ok

LoisRForgeFlow
LoisRForgeFlow approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow LoisRForgeFlow merged commit bd0aaed into OCA:11.0 Mar 28, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-add-mrp_bom_structure_report branch March 28, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@marcelofrare marcelofrare marcelofrare approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AdriaGForgeFlow @OCA-git-bot @LoisRForgeFlow @marcelofrare @HviorForgeFlow