Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in mrp_subcontracting_partner_management: No qty_received when delivering from one subcontractor to another #1024

Closed
david-fleischmann opened this issue Apr 28, 2023 · 19 comments
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@david-fleischmann
Copy link

david-fleischmann commented Apr 28, 2023

I found a bug in Subcontracting Partner Management

Module

mrp_subcontracting_partner_management

Describe the bug

When I purchase subcontracted products from one subcontractor (1) to another one (2) (for further manufacturing) and receive the stock picking at subcontractor (2) by validating the purchase.order qty_received when is still 0 although received.
Found this in debugging, but doesn't make sense to me for subcontracting workflow:
image

To Reproduce

Affected versions: 14 and 15

Steps to reproduce the behavior:

  1. Make a Purchase of a Subcontracted Product to another Subcontractor
  2. Receive The goods there
  3. In purchase order qty_received is still 0

image
image

Expected behavior
qty_received should be set according to the qty received in stock.picking
Additional context
With non subcontracting products it works perfectly

@francesco-ooops
Copy link
Contributor

@david-fleischmann would you be able to open a PR to fix this behavior?

@david-fleischmann
Copy link
Author

@francesco-ooops unfortunately i have no approach yet. Maybe I also understand it wrong, how do you deliver to your subcontractor from another vendor?

@elvise
Copy link

elvise commented May 31, 2023

hey @david-fleischmann thanks for your feedback we will check it

@david-fleischmann
Copy link
Author

david-fleischmann commented Jun 2, 2023

hey @david-fleischmann thanks for your feedback we will check it

@elvise thanks! :)

Those modules already helped a bit, since now it's considered as a dropship at least.:
https://github.com/OCA/stock-logistics-transport/tree/15.0
But still Received qty is 0.
And I found out this problem only occurs when I'm delivering subcontracted goods from one SubC to another. For non subcontracted goods it will set the qty as received.
image

@elvise
Copy link

elvise commented Jun 2, 2023

hey @david-fleischmann !
i’m studying this case, have you tested in the odoo V14 runbot ?

@david-fleischmann
Copy link
Author

@elvise
Yes, just did on http://oca-manufacture-14-0-f2092617ca99.runboat.odoo-community.org/:
BOM Subcontracted at sub1
image

PO Ordered at Sub1 Delivered to Sub2 and Received but qty received stays zero:
image
image

Receipt:
image

@elvise
Copy link

elvise commented Jun 2, 2023

@elvise Yes, just did on http://oca-manufacture-14-0-f2092617ca99.runboat.odoo-community.org/: BOM Subcontracted at sub1 image

PO Ordered at Sub1 Delivered to Sub2 and Received but qty received stays zero: image image

Receipt: image

Hi @david-fleischmann thanks for the reply, to test the standard behavior of odoo you have to run the tests in the odoo v14 runbot.

@david-fleischmann
Copy link
Author

david-fleischmann commented Jun 2, 2023

@elvise I did (on OCA runbot, bc there are the affected modules), as I wrote in first line:
http://oca-manufacture-14-0-f2092617ca99.runboat.odoo-community.org/:

@elvise
Copy link

elvise commented Jun 2, 2023

@david-fleischmann this is not the Odoo runbot but it's the OCA runbot, this is the of the Odoo Runbot

(Need to test the standard behaviour)

@david-fleischmann
Copy link
Author

david-fleischmann commented Jun 2, 2023

@elvise In standard you can't test it at all, since there is only one subcontractor location for all subcontractors. And you don't have an operation type there to deliver to another subcontractor. That's why I'm relying on your module.
But we could schedule a call to check this out anyway

@elvise
Copy link

elvise commented Jun 2, 2023

@david-fleischmann Sure we can schedule a call, but it would be great if you could replicate a simple configuration in the odoo runbot just so we know the bug is on this module. (I have some doubts, because this module creates locations and types of operations for subcontractors nothing more)

@elvise
Copy link

elvise commented Jun 2, 2023

@david-fleischmann

As I suspected!
I tested in odoo V14 CE runbot with the same setup:

Products

  • Finished > Subcontractor: SUB1
    • Semifinished > Subcontractor: SUB2
      • Element > Vendor: Vendor

I created a PO for the "Finished" product, a PO for the "Semifinished" product was automatically created and in Replenish I launched a PO for the "Element" product.

When I receive "Element" the QTY was updated while when I receive "Semifinished" the QTY was not updated.

@elvise
Copy link

elvise commented Jun 2, 2023

@david-fleischmann same test in V15 (odoo runbot) and QTY is updated

@david-fleischmann
Copy link
Author

@elvise so how would you suggest to proceed here?
I think something has to be added to that sbc partner management module to make it work properly

@elvise
Copy link

elvise commented Jun 5, 2023

@elvise so how would you suggest to proceed here?

I think something has to be added to that sbc partner management module to make it work properly

@david-fleischmann Good morning!
From my side we need to back port this module from V15 to V14

@david-fleischmann
Copy link
Author

@elvise this module is already in v15 and v14. I installed it at my customers location but it's still not working...

@francesco-ooops
Copy link
Contributor

Hi @david-fleischmann , would you like to take a look at #1082 ? I think that's what we need for the flow you describe

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@david-fleischmann
Copy link
Author

Hi @david-fleischmann , would you like to take a look at #1082 ? I think that's what we need for the flow you describe

@francesco-ooops as already stated in linked thread: thanks for your reply and digging into it! Will check it soon, didn't receive anymore notifications by github (spam folder...).
It really looks like this is the missing piece!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

3 participants