[FIX] mis_builder: Comparison percentages export format in XLSX #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
MaxyMoos
force-pushed
the
fix-xlsx-percentages-with-divider
branch
2 times, most recently
from
c32d65c
to
51fe61f
Compare
When a 'divider' style param is used on a kpi, it is also applied to the variation columns when exporting to Excel, which leads to errors of magnitude for the percentages displayed in the resulting XLSX file.
MaxyMoos
force-pushed
the
fix-xlsx-percentages-with-divider
branch
from
51fe61f
to
0c1795a
Compare
|
@sbidoul merge? |
|
/ocabot merge |
|
Hi @sbidoul. Your command failed:
Ocabot commands
More information
|
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at fc36a7c. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a divider/factor Style parameter is used on a KPI, it is also applied to the "Compare columns" when exporting to Excel, which leads to errors of magnitude for the percentages displayed in the resulting XLSX file.
Here is a simple report using a KPI with a style factor "1e3 - k" and with a compare column as it is displayed in Odoo :
And the resulting XLSX export:
Seen on 12.0 but it seems like 10.0 code is similar.