Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] partner_multi_company: Migration to 13.0 #266

Merged
merged 25 commits into from
Jan 12, 2021

Conversation

ernestotejeda
Copy link
Member

Cc @Tecnativa TT26933

Supersede #200

oihane and others added 25 commits January 12, 2021 11:16
This fix prevents errors when there are other tests that create partners
and base_suspend_security is still not ready. There can be still problems
if these partners are not created with SUPERUSER.
* Bump versions
* Rename manifest
* Rename openerp to odoo
* Implement base_multi_company

Add depends

Swap dependencies

Add base_suspend_security depend back & server-tools repo

Fix tests

Add test for partner._commercial_fields

Why not both?!
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: multi-company-11.0/multi-company-11.0-partner_multi_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-11-0/multi-company-11-0-partner_multi_company/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: multi-company-12.0/multi-company-12.0-partner_multi_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-partner_multi_company/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: multi-company-12.0/multi-company-12.0-partner_multi_company
Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-partner_multi_company/
In some situations the 'in' operator is used with company_id in a
name_search. ORM does not convert to a proper WHERE clause when using
the 'in' operator.
e.g: ```
     WHERE "res_partner"."id" in (SELECT "res_partner_id"
     FROM "res_company_res_partner_rel" WHERE "res_company_id" IN (False, 1)
```
patching the args to expand the cumbersome args int a OR clause fix
the issue.
e.g: ```
     WHERE "res_partner"."id" not in (SELECT "res_partner_id"
             FROM "res_company_res_partner_rel"
             where "res_partner_id" is not null)
         OR  ("res_partner"."id" in (SELECT "res_partner_id"
             FROM "res_company_res_partner_rel" WHERE "res_company_id" IN 1)
```
@pedrobaeza pedrobaeza added this to the 13.0 milestone Jan 12, 2021
@pedrobaeza
Copy link
Member

Merging as the other PR had another approval:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-266-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza mentioned this pull request Jan 12, 2021
12 tasks
@OCA-git-bot OCA-git-bot merged commit 24fb602 into OCA:13.0 Jan 12, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8cbe95f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet