-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] partner_multi_company: Migration to 13.0 #266
Merged
OCA-git-bot
merged 25 commits into
OCA:13.0
from
Tecnativa:13.0-mig-partner_multi_company
Jan 12, 2021
Merged
[13.0][MIG] partner_multi_company: Migration to 13.0 #266
OCA-git-bot
merged 25 commits into
OCA:13.0
from
Tecnativa:13.0-mig-partner_multi_company
Jan 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix prevents errors when there are other tests that create partners and base_suspend_security is still not ready. There can be still problems if these partners are not created with SUPERUSER.
* Bump versions * Rename manifest * Rename openerp to odoo * Implement base_multi_company Add depends Swap dependencies Add base_suspend_security depend back & server-tools repo Fix tests Add test for partner._commercial_fields Why not both?!
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-11.0/multi-company-11.0-partner_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-11-0/multi-company-11-0-partner_multi_company/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-partner_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-partner_multi_company/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-partner_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-partner_multi_company/
In some situations the 'in' operator is used with company_id in a name_search. ORM does not convert to a proper WHERE clause when using the 'in' operator. e.g: ``` WHERE "res_partner"."id" in (SELECT "res_partner_id" FROM "res_company_res_partner_rel" WHERE "res_company_id" IN (False, 1) ``` patching the args to expand the cumbersome args int a OR clause fix the issue. e.g: ``` WHERE "res_partner"."id" not in (SELECT "res_partner_id" FROM "res_company_res_partner_rel" where "res_partner_id" is not null) OR ("res_partner"."id" in (SELECT "res_partner_id" FROM "res_company_res_partner_rel" WHERE "res_company_id" IN 1) ```
pedrobaeza
approved these changes
Jan 12, 2021
Merging as the other PR had another approval: /ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 8cbe95f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @Tecnativa TT26933
Supersede #200