[17.0] [MIG] base_multi_company: Migration to 17.0 #624
Conversation
* Create new module to provide base multi company logic and mixin * Add deactivation by company mixin * Add company_id/ids handling * Add break after company is found Squashed commits: [854cc36] Increase test coverage [770bd71] Revert hook view create back to model init [40e803e] Fix apples and oranges [7a4dfb4] Use registry correctly [6e9f170] Switch company_id to computed & move company aliased view creation to post init hook [faa4fc9] Remove active functionality [fecfb59] Add explicit tests for active and inactive searches
* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
Squashed commits: [4c17d04] auto_join company_ids
…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py
- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore
* Add implementation instructions to ReadMe
[FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Bad branch version pushed before [FIX] Bad branch version pushed before [FIX] manifest Fix flake Flake8 on OCA tests
… are bound to some company
Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/
Odoo now checks if the user who creates the transient model is the same that is accessing its data, so we need to create it with the same user.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
* Abstract model shouldn't have default for `company_ids`. It will be got by default `company_id` value. * Record rule based on `company_id` makes the evaluation slower. Switch to `company_ids` field. * Add `@api.depends` to `company_id` computation for proper refresh. * Fix tests that were not correct but luckily previously suceeded. Now that other code has been removed, they have been uncovered.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/
Currently translated at 70.0% (7 of 10 strings) Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/zh_CN/
Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-16.0/multi-company-16.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-base_multi_company/it/
Currently translated at 100.0% (4 of 4 strings) Translation: multi-company-16.0/multi-company-16.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-base_multi_company/pt_BR/
|
/ocabot migration base_multi_company |
rven
force-pushed
the
17.0-mig-base_multi_company
branch
3 times, most recently
from
94d5e1f
to
503d1fb
Compare
|
I had a quick look at this and the domain seems to be not working properly, if there is no company set. I had to rewrite the domain to "['|', ('company_ids', '=', False), ('company_ids', 'in', company_ids)]" for it to work properly. I then had a look at the Odoo's code and Odoo also seems to use the one i gave for m2m in the iap module. @rven |
I didn't change this domain, it has been updated within the migration of v16 91088f1 |
|
It's incorrect on v16. To be fixed. Please fix it here. |
rven
force-pushed
the
17.0-mig-base_multi_company
branch
from
503d1fb
to
e96231b
Compare
|
@mohammedshahil @pedrobaeza Can you recheck the module with this change? |
|
@pedrobaeza Are you sure the domain was incorrect in v16? odoo/odoo@c18b9f4 |
|
Yes, in what you put, the left part is a many2one, not a many2many. This was discovered in #628. The question is that m2m doesn't handle correctly the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6e2b1c2. Thanks a lot for contributing to OCA. ❤️ |
No description provided.