Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set language_version for prettier #17

Merged
merged 2 commits into from Oct 8, 2020
Merged

Set language_version for prettier #17

merged 2 commits into from Oct 8, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 7, 2020

The default available on travis is too old.

fixes #15

@sbidoul sbidoul requested a review from yajo October 7, 2020 11:59
@sbidoul sbidoul added this to the v1.0.2 milestone Oct 7, 2020
@yajo
Copy link
Member

yajo commented Oct 8, 2020

Cool! I was trying to help @ernestotejeda to fix this the other day and didn't have a clue...

Do you think it'd make more sense to update the default_language_version instead for node, just like we have for python?

@yajo yajo added the hacktoberfest-accepted This PR is a candidate to win a T-shirt if done while the Hacktoberfest is live label Oct 8, 2020
@sbidoul
Copy link
Member Author

sbidoul commented Oct 8, 2020

Do you think it'd make more sense to update the default_language_version instead for node, just like we have for python?

Ok, I'll try that. It's probably more coherent to have the same node version for all hooks that need it.

@yajo
Copy link
Member

yajo commented Oct 8, 2020

Yes, that's what I thought.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 8, 2020

Gah, now tests fails here on poetry install...

@yajo
Copy link
Member

yajo commented Oct 8, 2020

Possibly a cache problem. I need admin access to this repo to fix it.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 8, 2020

@yajo I just gave you admin access.

@yajo
Copy link
Member

yajo commented Oct 8, 2020

Note: to apply this workaround: actions/cache#2 (comment)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 8, 2020

@yajo while you are at it you may want to look into #18

yajo pushed a commit to Tecnativa/oca-addons-repo-template that referenced this pull request Oct 8, 2020
Update action versions
e92a7c3 
Fixes OCA#18 and it will probably fix a cache problem affecting OCA#17.
@yajo yajo mentioned this pull request Oct 8, 2020
Merged
yajo pushed a commit to Tecnativa/oca-addons-repo-template that referenced this pull request Oct 8, 2020
Update action versions
1d54984 
Fixes OCA#18 and it will probably fix a cache problem affecting OCA#17.

- The pre-commit workflow uses the latest action version, which sets up cache automatically.
- The test workflow uses a new secret, `$CACHE_DATE`, which can be updated by a repo maintainer to sort of "clear" the cache.
@yajo
Copy link
Member

yajo commented Oct 8, 2020

After merging #19, if you rebase this will probably get fixed.

Otherwise, we can alter the $CACHE_DATE secret later, to force cache "clearing", and again it should get fixed.

@sbidoul
Set language_version for prettier
f2ea483 
The default available on travis is too old.
Fixes #15
@sbidoul
Set default node version
be7309b
@sbidoul
Copy link
Member Author

sbidoul commented Oct 8, 2020

Ok, green. Almost there.

@sbidoul sbidoul merged commit f1196b6 into master Oct 8, 2020
@OCA-git-bot OCA-git-bot deleted the prettier-node-version branch October 8, 2020 09:33
@joao-p-marques joao-p-marques mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo Awaiting requested review from yajo

Assignees
No one assigned
Labels
hacktoberfest-accepted This PR is a candidate to win a T-shirt if done while the Hacktoberfest is live needs review
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

prettier requires at least version 10.13.0 of Node, please upgrade
3 participants
@sbidoul @yajo @OCA-git-bot