Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocabot merge: update HISTORY.rst, using oca-towncrier #106

Merged
merged 1 commit into from Mar 28, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 24, 2020

This PR makes the "ocabot merge" command update HISTORY.rst from fragments in readme/newsfragment using a thin oca specific wrapper for towncrier.

@sbidoul sbidoul force-pushed the towncrier-sbi branch 2 times, most recently from c771552 to d5a25b8 Compare March 25, 2020 11:46
@sbidoul sbidoul marked this pull request as ready for review March 25, 2020 11:47
@sbidoul sbidoul changed the title [WIP] towncrier Update HISTORY.rst in ocabot merge, using oca-towncrier Mar 25, 2020
@sbidoul
Copy link
Member Author

sbidoul commented Mar 25, 2020

@legalsylvain

@sbidoul sbidoul force-pushed the towncrier-sbi branch 2 times, most recently from baa97b5 to c00e27d Compare March 25, 2020 12:13
@sbidoul sbidoul changed the title Update HISTORY.rst in ocabot merge, using oca-towncrier ocabot merge: update HISTORY.rst, using oca-towncrier Mar 25, 2020
@sbidoul
Copy link
Member Author

sbidoul commented Mar 28, 2020

Ok, the general feedback in the original issue was positive, so I'm going to merge this and cut a release. It's fully opt-in so there is no risk and we can fine tune based on field feedback.

@sbidoul sbidoul merged commit cb5f1f1 into OCA:master Mar 28, 2020
@sbidoul sbidoul deleted the towncrier-sbi branch March 28, 2020 10:58
@sbidoul
Copy link
Member Author

sbidoul commented Mar 28, 2020

This works, here are two commits it just made: OCA/mis-builder@655e93e and OCA/mis-builder@c6b8457 following OCA/mis-builder#254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant