[IMP] make APPROVALS_REQUIRED configurable

[legalsylvain]

For the time being, APPROVALS_REQUIRED is hardcoded with the value 2.

With that PR, it is configurable.

Note : It is not the perfect design, as the approvals number is dynamic, in the real (OCA) life, and depends on the state of the modules. (stable / Beta / etc...) but it is a little step forward.

Make also MIN_PR_AGE configurable.

[sbidoul]

LGTM, can you add the newsfragment? 107.feature in this case.

Suggestion: "Add APPROVALS_REQUIRED and MIN_PR_AGE configuration options to control the conditions to set the Approved label."

[legalsylvain]

Ok ! Thanks for the review ! A little out of topic but I was thinking to the interest to implement two levels if the approval is green (comes from maintainers of the repo) or white (comes from any people) do you think it's relevant ? Usefull for the OCA ?

[sbidoul]

two levels if the approval is green (comes from maintainers of the repo) or white (comes from any people)

Could be useful yes. To determine who is a green approver, we could use user_can_push from #71. A separate PR could first refactor _user_can_merge into user_can_push.

[legalsylvain]

Hi @sbidoul

• fragment added.
• I will do another PR for adding a MAINTAINERS_APPROVALS_REQUIRED coming soon. you can proceed with this one, if you think all is OK.