Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Dependabot in check-suite #115

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented May 20, 2020

The check-suites GitHub api-call started reporting Dependabot in queued state, preventing merges.
It should be safe to ignore it by default.

The check-suites api-call started reporting Dependabot
in queued state, preventing merges. It should be safe
to ignore it by default.
@pedrobaeza
Copy link
Member

Isn't better strategy instead of this to use a whitelist type (saying which are included) instead of a blacklist (ignoring what we don't want)?

@sbidoul
Copy link
Member Author

sbidoul commented May 20, 2020

use a whitelist

By default all checks must be green to merge. Here I'd say it's a bug with Dependabot. It should not appear as a check.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's continue then with this approach, and I merge as we don't expect more reviews

@pedrobaeza pedrobaeza merged commit 6e30867 into OCA:master May 20, 2020
@sbidoul sbidoul deleted the ignore-dependabot-sbi branch May 20, 2020 16:29
@pedrobaeza pedrobaeza mentioned this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants