[FIX] attribute_set_completeness: speed up completion fields #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cedric-Pigeon
force-pushed
the
10.0-completeness-speed
branch
2 times, most recently
from
5aed120
to
54a4bac
Compare
Cedric-Pigeon
force-pushed
the
10.0-completeness-speed
branch
from
54a4bac
to
bbf3744
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 71772f0. Thanks a lot for contributing to shopinvader. ❤️ |
simahawk
reviewed
Oct 1, 2020
| from odoo.addons.component_event import skip_if | ||
|
|
||
|
|
||
| class AttributeSetOwnerEventListener(AbstractComponent): |
There was a problem hiding this comment.
@Cedric-Pigeon in this case a simple override of write would have been enough IMO :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As completion fields are used a lot for searches purposes, we need to store them in the database to speed up results.
As we can not simply use
store=Truebecause the depends fields are variable and dynamically defined on the attribute_set, this PR aims to use en event listener at each write/create