[IMP] update_module_names: Add merge option

[pedrobaeza]

With these minimal changes, we allow to reallocate all the resources related to a module that has been merged into others in later versions. For example, email_template in version 8 that has been integrated in mail module in version 9.

[pedrobaeza]

cc @Tecnativa

[pedrobaeza]

Travis error unrelated

[pedrobaeza]

@moylop260, do you have any tip why this fails?

[moylop260]

Maybe is a flake8-3.2.1 error

flake8 OCA/openupgradelib
Traceback (most recent call last):
  File "flake8", line 11, in <module>
    sys.exit(main())
  File "flake8/main/cli.py", line 16, in main
    app.run(argv)
  File "flake8/main/application.py", line 322, in run
    self._run(argv)
  File "flake8/main/application.py", line 306, in _run
    self.run_checks()
  File "flake8/main/application.py", line 243, in run_checks
    self.file_checker_manager.start(files)
  File "/flake8/checker.py", line 371, in start
    self.make_checkers(paths)
  File "/flake8/checker.py", line 285, in make_checkers
    if argument == filename or should_create_file_checker(filename)
  File "/flake8/checker.py", line 412, in __init__
    self.display_name = self.processor.filename
AttributeError: 'NoneType' object has no attribute 'filename'

[moylop260]

It could be related with https://gitlab.com/pycqa/flake8/issues/272

[pedrobaeza]

It seems so. Thanks for the info. Is in our hands to repair it?

[moylop260]

Options

1. Wait the next releases
2. Freeze a old stable version in pip install command

[pedrobaeza]

OK, I think we should choose option 2, isn't it? We did the same on MQT if I don't remember bad.

[moylop260]

This project is not using MQT
Use directly flake8 command from .travis.yml

[pedrobaeza]

Yeah, I know, that's why I tell to do the same.

[moylop260]

We have freeze pylint version from pylint-odoo but flake8 is not freeze

[moylop260]

FYI using
flake8 --version
2.4.1 (pep8: 1.7.0, mccabe: 0.5.2, pyflakes: 0.8.1) CPython 2.7.10 on Darwin

flake8 openupgradelib/
the result was:

openupgradelib/openupgrade_tools.py:31:1: E302 expected 2 blank lines, found 1
openupgradelib/openupgrade.py:101:5: F811 redefinition of unused 'RegistryManager' from line 58

[hbrunn]

what do you think about having a new function to merge module A into B instead? This way, we can account for situations where multiple modules are replaced by another one, and the execution path will be a lot less complicated

[pedrobaeza]

I preferred to use the same method for not duplicating code. You can still perform the merge of multiple modules into one:

update_module_names([('B', 'A'), ('C', 'A',), ('D', 'A')], merge_modules=True)

[pedrobaeza]

This is finally working as I have fixed Travis.

@hbrunn @yajo @cubells, can any of you please check?

[pedrobaeza]

As we have already tested this feature and need it for a lot of current PRs, I concede myself the luxury of merging it.