[MIG] Migrate account_operating_unit to 11.0

[michael-villamar]

No description provided.

[pedrobaeza]

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

[richard-willdooit]

@pedrobaeza - we are not getting enough information from runbot to see why this is failing?

[pedrobaeza]

Yes, you can: just click on Details here, click on the gears, and "Full all logs". There, you see the warning that is causing this to go to red:

2018-04-16 01:57:47,530 168 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view report_financial_operating_units (): use the hasclass(*classes) function to filter elements by their classes
2018-04-16 01:57:47,555 168 WARNING openerp_test odoo.addons.base.ir.ir_ui_view: Error-prone use of @class in view report_trialbalance_operating_units (): use the hasclass(*classes) function to filter elements by their classes

[emagdalenaC2i]

Is this duplicate with #101 ?

[AaronHForgeFlow]

As @emagdalenaC2i said, the analytic_operating_unit module is already proposed to v11 at #101. However, AFAIK the account_operating_unit is not proposed in another PR so @michael-villamar can propose it here.

[meigallodixital]

We apply this PR on local, and all appears works well. But we have a doubt, there are any way to have or tag account journals by operating unit?

[AaronHForgeFlow]

@meigallodixital no, the operating unit is not in the journals, not sure if it is easy to implement that or not. Anyway, as long as the operating unit is in the journal items the accounting is clearly separated between operating units.

@michael-villamar can you remove the analytic_operating_unit module from this PR? That one is proposed on #101 you can still propose the account_operating_unit here.

[meigallodixital]

To clarify, in our case we have installed the analytic_operating_unit from #101 and account_operating_unit from #114 :)

[AaronHForgeFlow]

@meigallodixital yes that's correct. :)

[meigallodixital]

Now that the analytic PR is merged into the main branch, it would be good to prepare and give a boost to this account_operating_unit module.

No issues in the account module with the changes from this PR on my local enviroment (OCB).

[AaronHForgeFlow]

@michael-villamar can you remove the analytic_operating_unit changes from this PR? It is already merged. Thank you!

[meigallodixital]

What is pending to accept this module?

[AaronHForgeFlow]

@meigallodixital basically more reviews. I haven't had the time so far to review, but fixing the conflicts would make this easier to reviews by others.

[meigallodixital]

I think there are no conflicts in the merge with the base branch. It is more lack of tests to cover all the codecoverage if I'm not wrong ...

[AaronHForgeFlow]

No, I'm getting a message: "This branch cannot be rebased due to conflicts". Also, the commit history is not respected. @michael-villamar If you agree I can fix that here in this PR.

[michael-villamar]

No problem with me @aheficent