Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] hr_contract_operating_unit #161

Merged
merged 8 commits into from May 31, 2019
Merged

[12.0][MIG] hr_contract_operating_unit #161

merged 8 commits into from May 31, 2019

Conversation

AdriaGForgeFlow
Copy link
Contributor

Standard migration or hr_contract_operating_unit to v12

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jan 22, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 22, 2019
Closed
11 tasks
AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional test

nikul-serpentcs
nikul-serpentcs suggested changes Jan 22, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Change

hr_contract_operating_unit/__manifest__.py Outdated
"author": "Eficent Business and IT Consulting Services S.L., "
"Serpent Consulting Services Pvt. Ltd.,"
"Odoo Community Association (OCA)",
"website": "http://www.eficent.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ageficent URL should be https://github.com/OCA/operating-unit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

tbaden
tbaden approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikul-serpentcs can you please recheck your review. changes were made.

nikul-serpentcs
nikul-serpentcs approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

Need to fixup last commit

@AaronHForgeFlow AaronHForgeFlow force-pushed the 12.0-mig-hr_contract_operating_unit branch from 07fe22f to 0810662 Compare May 31, 2019 17:27
@AaronHForgeFlow
Copy link
Contributor

Fixed up. Will merge as soon as ci green

@AaronHForgeFlow AaronHForgeFlow merged commit 2b730dc into OCA:12.0 May 31, 2019
@AaronHForgeFlow AaronHForgeFlow deleted the 12.0-mig-hr_contract_operating_unit branch May 31, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaden tbaden tbaden approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@AdriaGForgeFlow @OCA-git-bot @AaronHForgeFlow @tbaden @nikul-serpentcs @pedrobaeza @SerpentCS @serpentcs-dev1