Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 13.0 Migration of module hr_expense_operating_unit #251

Merged
merged 19 commits into from
Apr 16, 2020
Merged

[MIG] 13.0 Migration of module hr_expense_operating_unit #251

merged 19 commits into from
Apr 16, 2020

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Feb 12, 2020 •
edited
Loading

Depends on #229

@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from 8fe50d7 to 7add024 Compare February 12, 2020 22:02
@alan196 alan196 mentioned this pull request Feb 12, 2020
Closed
14 tasks
@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from 7add024 to a2bdc13 Compare April 15, 2020 18:23
@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from a2bdc13 to a8924f0 Compare April 15, 2020 18:29
lmgr0312
lmgr0312 approved these changes Apr 15, 2020
View reviewed changes
Copy link

@lmgr0312 lmgr0312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

AaronHForgeFlow
AaronHForgeFlow requested changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've found a bug (probably it is also in v12). I created an expense report for "Main Operating Unit" with some expense lines for "Main Operating Unit". Then I changed the operating unit of the expense report to "B2B". However, the operating unit of the expense line remain as "Main Operating Unit". Seems incorrect.

@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from a8924f0 to 9c9f46e Compare April 16, 2020 14:58
@alan196
Copy link
Contributor Author

alan196 commented Apr 16, 2020

@AaronHForgeFlow I fix the bug you mention. Could you help me to review again 🙏

@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from 9c9f46e to 1f33075 Compare April 16, 2020 15:55
AaronHForgeFlow
AaronHForgeFlow approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional test. Merging as soon as green Thanks

@alan196 alan196 force-pushed the 13.0-mig-hr_expense_operating_unit branch from 1f33075 to 88edf03 Compare April 16, 2020 16:04
@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-251-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 0d88376 into OCA:13.0 Apr 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 10183ff. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 13.0-mig-hr_expense_operating_unit branch April 16, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmgr0312 lmgr0312 lmgr0312 approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@alan196 @AaronHForgeFlow @OCA-git-bot @lmgr0312 @SerpentCS @LoisRForgeFlow @nikul-serpentcs @bjeficent @oca-travis