[9.0] sales_team_operating_unit #35

JordiBForgeFlow · 2016-10-05T18:25:42Z

No description provided.

pedrobaeza · 2016-10-05T20:47:54Z

crm_operating_unit/models/crm_lead.py

+    @api.multi
+    @api.constrains('team_id', 'operating_unit_id')
+    def _check_team_operating_unit(self):
+        for rec in self:


This constraint has no sense. Makes a related field if you want this behavior.

The team_id is not a required field in the lead. You might have a lead for an operating unit not associated to a sales team.

Yeah, but if present, you're not allowing to change it, so it doesn't make too much sense to have it. Also the message is not correct. It says 'company' instead of operating unit.

pedrobaeza · 2016-10-05T20:48:13Z

sales_team_operating_unit/README.rst

+
+* Adds the Operating Unit (OU) to the Sales Team.
+
+* The user’s default Operating Unit (OU) is proposed at the time of creating


pedrobaeza · 2016-10-05T20:49:03Z

crm_operating_unit/models/crm_lead.py



 class CRMLead(models.Model):

    _inherit = 'crm.lead'

+    @api.model


You can't add this code here, as there's no dependency to the other module. Do it in the proper module.

Now, there's dependency. I think it's ok, isn't it?

pedrobaeza · 2016-10-05T20:49:39Z

sales_team_operating_unit/models/crm_team.py

@@ -0,0 +1,16 @@
+# -*- coding: utf-8 -*-
+# © 2015 Eficent Business and IT Consulting Services S.L. -
+# Jordi Ballester Alomar


Don't include 2 copyright lines. Make it in one

pedrobaeza · 2016-10-05T20:50:25Z

sales_team_operating_unit/tests/test_crm_team_operating_unit.py

+        # Groups
+        self.grp_sale_mngr = self.env.ref('base.group_sale_manager')
+        self.grp_user = self.env.ref('base.group_user')
+        # Company


There's no need for these comments. You can use significant variable names instead.

AaronHForgeFlow · 2016-11-09T14:16:21Z

As long as crm depends on sales_team, crm_operating_unit depends on sales_team_operating_unit. Consequently this PR changes crm_operating_unit to adapt the tests.

coveralls · 2016-11-09T14:18:29Z

Coverage decreased (-0.8%) to 73.786% when pulling da757c9 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

coveralls · 2017-01-17T12:47:28Z

Coverage decreased (-0.8%) to 73.786% when pulling bba2ca6 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

coveralls · 2017-01-17T12:47:28Z

Coverage decreased (-0.8%) to 73.786% when pulling bba2ca6 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

AaronHForgeFlow · 2017-01-17T13:28:02Z

I Don't know why coverage decreases, IMO tests cover all what this module introduces.

pedrobaeza · 2017-01-17T13:30:45Z

Default method is not being tested:

Call crm_team standard to get team

AaronHForgeFlow · 2017-01-17T17:56:18Z

Thank you @pedrobaeza

coveralls · 2017-01-17T18:00:10Z

Coverage increased (+0.5%) to 75.081% when pulling 51b5d05 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

coveralls · 2017-01-17T18:00:10Z

Coverage increased (+0.5%) to 75.081% when pulling 51b5d05 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

coveralls · 2017-01-17T18:00:10Z

Coverage increased (+0.5%) to 75.081% when pulling 51b5d05 on Eficent:9.0-sales_team_operating_unit into 5ab00c3 on OCA:9.0.

guewen · 2017-01-23T10:50:21Z

@pedrobaeza can you reconsider your review? thanks

JordiBForgeFlow · 2017-01-23T17:01:24Z

The review from @pedrobaeza refers to the module crm, that has already been merged.

* [ADD] sales_team_operating_unit

pedrobaeza requested changes Oct 5, 2016

View reviewed changes

AaronHForgeFlow mentioned this pull request Nov 2, 2016

Migration to v9 - Sprint P1 #16

Closed

11 tasks

JordiBForgeFlow and others added 9 commits November 9, 2016 13:29

[ADD] sales_team_operating_unit

75e0f82

[FIX] add sales team as dependency of crm_operating_unit

320a4ea

[FIX] Comments by @pedrobaeza. Check the team in the SO

913d7e4

[FIX] Travis issues

1a57ff5

[FIX] It does not depend on sale

3d46366

[FIX] Typo error

831b91e

[FIX] Sales team instance have to be created using registry

8ca0549

[FIX] Travis + error in test_crm

6a0c556

[REV] crm_operating_unit is merged and this PR should not change it

d0ee4ea

AaronHForgeFlow force-pushed the 9.0-sales_team_operating_unit branch from a3ad6d4 to d0ee4ea Compare November 9, 2016 12:29

AaronHForgeFlow added 2 commits November 9, 2016 13:31

[FIX] typo error in readme

1c18486

[FIX] crm_operating_unit depends on sales_team_operating_unit

da757c9

alan196 approved these changes Nov 21, 2016

View reviewed changes

AaronHForgeFlow added 2 commits January 17, 2017 11:26

[IMP] Add test coverage

b62e134

[FIX] OU in the lead is related to the team

bba2ca6

[FIX] Improve test.

51b5d05

Call crm_team standard to get team

guewen approved these changes Jan 23, 2017

View reviewed changes

JordiBForgeFlow merged commit 552dd65 into OCA:9.0 Jan 23, 2017

JordiBForgeFlow added a commit that referenced this pull request Jan 30, 2017

sales_team_operating_unit (#35)

68487c1

* [ADD] sales_team_operating_unit

JordiBForgeFlow added a commit that referenced this pull request Mar 20, 2018

sales_team_operating_unit (#35)

323e992

* [ADD] sales_team_operating_unit

tschanzt pushed a commit to camptocamp/operating-unit that referenced this pull request May 23, 2018

sales_team_operating_unit (OCA#35)

c48eb72

* [ADD] sales_team_operating_unit

AaronHForgeFlow pushed a commit that referenced this pull request Nov 28, 2018

sales_team_operating_unit (#35)

ee99d06

* [ADD] sales_team_operating_unit

alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Dec 29, 2019

sales_team_operating_unit (OCA#35)

eb980ce

* [ADD] sales_team_operating_unit

alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Dec 31, 2019

sales_team_operating_unit (OCA#35)

11e9f7f

* [ADD] sales_team_operating_unit

alan196 referenced this pull request in Jarsa/operating-unit Feb 13, 2020

sales_team_operating_unit (#35)

c03caa4

* [ADD] sales_team_operating_unit

alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Oct 10, 2020

sales_team_operating_unit (OCA#35)

d7ad918

* [ADD] sales_team_operating_unit

alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Oct 15, 2020

sales_team_operating_unit (OCA#35)

b739956

* [ADD] sales_team_operating_unit

Rajan-SCS pushed a commit to Rajan-SCS/operating-unit that referenced this pull request Jan 12, 2022

[PATCH 01/23] sales_team_operating_unit (OCA#35)

28dc027

* [ADD] sales_team_operating_unit

Rajan-SCS pushed a commit to Rajan-SCS/operating-unit that referenced this pull request Jan 18, 2022

sales_team_operating_unit (OCA#35)

31bb88c

* [ADD] sales_team_operating_unit

BT-aleonard pushed a commit to BT-aleonard/operating-unit that referenced this pull request May 11, 2023

sales_team_operating_unit (OCA#35)

68470cd

* [ADD] sales_team_operating_unit

olveracuenca pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Jun 7, 2023

sales_team_operating_unit (OCA#35)

f8cbf0c

* [ADD] sales_team_operating_unit

alan196 referenced this pull request in Jarsa/operating-unit Jun 26, 2023

sales_team_operating_unit (#35)

51d14c6

* [ADD] sales_team_operating_unit

alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Jul 27, 2023

sales_team_operating_unit (OCA#35)

4200ca6

* [ADD] sales_team_operating_unit

jdidderen-nsi pushed a commit to jdidderen-nsi/operating-unit that referenced this pull request May 29, 2024

sales_team_operating_unit (OCA#35)

e4e1a54

* [ADD] sales_team_operating_unit

jdidderen-nsi pushed a commit to jdidderen-nsi/operating-unit that referenced this pull request Jul 8, 2024

sales_team_operating_unit (OCA#35)

5e64323

* [ADD] sales_team_operating_unit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0] sales_team_operating_unit #35

[9.0] sales_team_operating_unit #35

JordiBForgeFlow commented Oct 5, 2016

pedrobaeza Oct 5, 2016

JordiBForgeFlow Oct 5, 2016

JordiBForgeFlow Oct 5, 2016

pedrobaeza Oct 5, 2016

pedrobaeza Oct 5, 2016

pedrobaeza Oct 5, 2016

AaronHForgeFlow Jan 17, 2017

pedrobaeza Oct 5, 2016

pedrobaeza Oct 5, 2016

AaronHForgeFlow commented Nov 9, 2016 •

edited

Loading

coveralls commented Nov 9, 2016 •

edited

Loading

coveralls commented Jan 17, 2017 •

edited

Loading

coveralls commented Jan 17, 2017

AaronHForgeFlow commented Jan 17, 2017 •

edited

Loading

pedrobaeza commented Jan 17, 2017

AaronHForgeFlow commented Jan 17, 2017

coveralls commented Jan 17, 2017

coveralls commented Jan 17, 2017

coveralls commented Jan 17, 2017

guewen commented Jan 23, 2017

JordiBForgeFlow commented Jan 23, 2017


		* Adds the Operating Unit (OU) to the Sales Team.

		* The user’s default Operating Unit (OU) is proposed at the time of creating

[9.0] sales_team_operating_unit #35

[9.0] sales_team_operating_unit #35

Conversation

JordiBForgeFlow commented Oct 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Nov 9, 2016 • edited Loading

coveralls commented Nov 9, 2016 • edited Loading

coveralls commented Jan 17, 2017 • edited Loading

coveralls commented Jan 17, 2017

AaronHForgeFlow commented Jan 17, 2017 • edited Loading

pedrobaeza commented Jan 17, 2017

AaronHForgeFlow commented Jan 17, 2017

coveralls commented Jan 17, 2017

coveralls commented Jan 17, 2017

coveralls commented Jan 17, 2017

guewen commented Jan 23, 2017

JordiBForgeFlow commented Jan 23, 2017

AaronHForgeFlow commented Nov 9, 2016 •

edited

Loading

coveralls commented Nov 9, 2016 •

edited

Loading

coveralls commented Jan 17, 2017 •

edited

Loading

AaronHForgeFlow commented Jan 17, 2017 •

edited

Loading