10.0 mig sales team operating unit #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on #45 |
* [ADD] sales_team_operating_unit
LoisRForgeFlow
force-pushed
the
10.0-mig-sales_team_operating_unit
branch
from
c7e6ecb
to
5225dc1
Compare
serpentcs-dev1
suggested changes
Jan 27, 2017
| # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html). | ||
| from odoo import api, fields, models, _ | ||
| from odoo.exceptions import UserError | ||
|
|
There was a problem hiding this comment.
@lreficent unused, it is blocking flake8 can you please remove it?
There was a problem hiding this comment.
It wasn't in that file. But yes, it should be ok now.
There was a problem hiding this comment.
@lreficent Sorry my mistake it has to removed from test cases but instead we removed from crm_team.py
So you need to add the import again to py file and remove it from test cases.
LoisRForgeFlow
force-pushed
the
10.0-mig-sales_team_operating_unit
branch
from
4019654
to
bd59b8d
Compare
|
This seems fine. Can you review? @jbeficent @aheficent @mreficent |
serpentcs-dev1
approved these changes
Jan 27, 2017
LoisRForgeFlow
force-pushed
the
10.0-mig-sales_team_operating_unit
branch
from
74e2b43
to
f19385e
Compare
JordiBForgeFlow
approved these changes
Jan 30, 2017
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sales Team Operating Unit
This module introduces the following features:
Adds the Operating Unit (OU) to the Sales Team.
The user's default Operating Unit (OU) is proposed at the time of creating
the Sales Team.
Security rules are defined to ensure that users can only see the Sales Team
of that Operating Units in which they are allowed access to.