[13.0][FIX] base_location: address field sync zip_id #1180
Conversation
`_address_fields` are used by `update_address` [1], which is in turn called by `_fields_sync` and `_children_sync`. This mechanism is in charge of synchronizing parent/children address fields for contacts of type == "contact", as they don't really have an address of their own. They simply copy the address of their parent. Without this fix, not only the zip_id is not sync'ed, but also in some cases an exception may be raised by `_check_zip_id`, due to only some fields being sync'ed but not all, creating inconsistencies between zip_id and other address fields. [1]: https://github.com/odoo/odoo/blob/20648ef21/odoo/addons/base/models/res_partner.py#L429
victoralmau
force-pushed
the
13.0-fix-base_location-address_sync
branch
from
ae9cede
to
5997558
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1180-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 92f00d2. Thanks a lot for contributing to OCA. ❤️ |
|
I suppose this is needed in v14 and v15 |
|
|
But for |
|
This module re-defines the |
|
Not really, they are computed writable fields, so they act as onchanges, so no propagation is done that way AFAIK. |
FWP from 13.0: #1150
_address_fieldsare used byupdate_address1, which is in turncalled by
_fields_syncand_children_sync.This mechanism is in charge of synchronizing parent/children address fields
for contacts of type == "contact", as they don't really have an address of
their own. They simply copy the address of their parent.
Without this fix, not only the zip_id is not sync'ed, but also in some cases
an exception may be raised by
_check_zip_id, due to only some fields beingsync'ed but not all, creating inconsistencies between zip_id and other address
fields.
Please @pedrobaeza @joao-p-marques can you review it?
@Tecnativa TT33047