[7.0] Add module 'partner_address_street_3' #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two PEP8 issues: A README.rst file is missing. |
gurneyalex
force-pushed
the
7.0-street3
branch
from
b23b18e
to
61acab2
Compare
|
failure on runbot is caused by unrelated warnings. |
| Contributors | ||
| ------------ | ||
|
|
||
| * Firstname Lastname <email.address@example.org> |
|
👍 After minor remarks fixed |
| { | ||
| 'name': 'Street3 in addresses', | ||
| 'version': '0.1', | ||
| 'author': 'Camptocamp', |
There was a problem hiding this comment.
Add OCA as author so it shows up in the odoo app store
gurneyalex
force-pushed
the
7.0-street3
branch
from
0e4a730
to
d459f37
Compare
gurneyalex
force-pushed
the
7.0-street3
branch
from
d459f37
to
ff1843a
Compare
This was referenced Dec 16, 2015
| ############################################################################## | ||
| { | ||
| 'name': 'Street3 in addresses', | ||
| 'version': '7.0.0.1.0', |
There was a problem hiding this comment.
Shouldn't this be 7.0.1.0.0?
There was a problem hiding this comment.
I'm using the same number as the 8.0 version from which this was ported.
There was a problem hiding this comment.
Well, OK, usually the first version arriving to OCA has the 1.0.0 version milestone, but not a blocking issue.
|
👍 |
pedrobaeza
added a commit
that referenced
this pull request
Jan 18, 2016
[7.0] Add module 'partner_address_street_3'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport the addon from 8.0
rebased #60