Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] partner_multi_relation: Migration to 17.0 #1666

Merged
merged 38 commits into from
Apr 22, 2024

Conversation

SonoDavid
Copy link

[MIG] partner_multi_relation: Migration to 17.0

NL66278 and others added 29 commits February 14, 2024 11:15
* API of _auto_init
* Menu and groups
  stuff has moved from base to sales_team in odoo 10
* Fix error on search when leaf is (1, '=', 1)
* Another comparison fix with search arguments
* Update README
* Python 2to3
* Move relation menus items under contacts
* Fix date comparison
* Fix cache invalidate on relation write
* Bump module version
* Remove test_relation_type_unlink_dberror

  This test is not required because it tests a standard behavior of SQL.
  If a foreign key column is not nullable, then the foreign row can not be deleted.

* Remove utf8 encoding comment
* Add missing dependency for partner_multi_relation
* Add missing active_test in view action
* Bug Fix
* Enable additional columns on res_partner_relation_all.

  Enable to add additional columns from res_partner_relation in the sql view of res_partner_relation_all.

* Only require inverse_name when relation type is not symmetric
* Remove deprecated @api.one and replace openerp with odoo
* Add website to manifest
* Prevent disabling allow_self if reflexive relations exist
* Enable deleting/ending invalid relations after deactivating reflexivity.
* Handle case of invalid future reflexive relations
Currently translated at 86.6% (84 of 97 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_multi_relation/es/
Fix for error when opening a contact and clicking the smart button.

Error Information:
  File "/opt/odoo/v12/src/partner-contact/partner_multi_relation/models/res_partner.py", line 187, in action_view_relations
    action['context'].\
AttributeError: 'str' object has no attribute 'update'
Currently translated at 46.4% (45 of 97 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_multi_relation/it/
Currently translated at 100.0% (97 of 97 strings)

Translation: partner-contact-13.0/partner-contact-13.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_multi_relation/es_AR/
In Odoo v14, ir.actions.act_window have only access rights for admin while a user had read access in previous versions. Odoo provides now a function (_for_xml_id) that returns the action read with sudo.
Currently translated at 100.0% (97 of 97 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_multi_relation/pt/
@SonoDavid SonoDavid mentioned this pull request Feb 14, 2024
62 tasks
badbole and others added 6 commits April 16, 2024 15:17
Currently translated at 44.7% (43 of 96 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/hr/
Currently translated at 98.9% (95 of 96 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/it/
Currently translated at 85.4% (82 of 96 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/sl/
Currently translated at 100.0% (96 of 96 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/es/
Currently translated at 100.0% (96 of 96 strings)

Translation: partner-contact-16.0/partner-contact-16.0-partner_multi_relation
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_multi_relation/it/
@SonoDavid SonoDavid force-pushed the 17.0-mig-partner_multi_relation branch 4 times, most recently from d9a8254 to 9d4b580 Compare April 16, 2024 13:35
@SonoDavid
Copy link
Author

I updated the repo according to comments Crogos

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History LGTM. What I've tested worked.
Some more coding style findings.

partner_multi_relation/models/res_partner_relation.py Outdated Show resolved Hide resolved
partner_multi_relation/models/res_partner_relation_all.py Outdated Show resolved Hide resolved
partner_multi_relation/models/res_partner_relation_type.py Outdated Show resolved Hide resolved
partner_multi_relation/models/res_partner_relation_type.py Outdated Show resolved Hide resolved
@SonoDavid SonoDavid force-pushed the 17.0-mig-partner_multi_relation branch from 9d4b580 to e956cf4 Compare April 17, 2024 09:05
@SonoDavid
Copy link
Author

Fixed the strings.

@SonoDavid SonoDavid force-pushed the 17.0-mig-partner_multi_relation branch from e956cf4 to abd90be Compare April 17, 2024 15:17
@SonoDavid
Copy link
Author

SonoDavid commented Apr 17, 2024

Fix more strings. Who will merge this repo?

Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link

CRogos commented Apr 22, 2024

@pedrobaeza can you merge?

@pedrobaeza
Copy link
Member

/ocabot migration partner_multi_relation
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 22, 2024
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1666-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 55414b2 into OCA:17.0 Apr 22, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5938ad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet