Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD] partner_manual_rank #1744

Merged
merged 1 commit into from
May 19, 2024
Merged

[UPD] partner_manual_rank #1744

merged 1 commit into from
May 19, 2024

Conversation

vnikolayev1
Copy link

@vnikolayev1 vnikolayev1 commented Apr 23, 2024

  • backported supplier and customer calculation from v15.0 - Fixes part when parent partner is supplier, and if we have child who is not - it turns off supplier boolean for parent, which should not happen

def _inverse_is_customer(self):

@vnikolayev1
Copy link
Author

@TDu

@vnikolayev1
Copy link
Author

@mt-software-de

Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been good to backport the tests as well.

Copy link

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport the tests as well.

- backported supplier and customer calculation from v15.0
@vnikolayev1
Copy link
Author

vnikolayev1 commented Apr 29, 2024

@mt-software-de @TDu done, tested on my machine, all works fine

Copy link

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mt-software-de
Copy link

@OCA/crm-sales-marketing-maintainers can someone merge this PR?

@NL66278
Copy link
Contributor

NL66278 commented Apr 29, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1744-by-NL66278-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
Signed-off-by NL66278
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1744-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1744-by-NL66278-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Sponsor Member

dreispt commented May 19, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1744-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9ad9276 into OCA:14.0 May 19, 2024
1 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b698f1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants