-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPD] partner_manual_rank #1744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been good to backport the tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please backport the tests as well.
- backported supplier and customer calculation from v15.0
@mt-software-de @TDu done, tested on my machine, all works fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@OCA/crm-sales-marketing-maintainers can someone merge this PR? |
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1744-by-NL66278-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
1 similar comment
@NL66278 your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1744-by-NL66278-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 5b698f1. Thanks a lot for contributing to OCA. ❤️ |
partner-contact/partner_manual_rank/models/res_partner.py
Line 46 in e7d7e4a