Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] partner_property: New module #1785

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[16.0][ADD] partner_property: New module #1785

merged 1 commit into from
Jun 27, 2024

Conversation

victoralmau
Copy link
Member

New module

Please @pedrobaeza can you review it?

@Tecnativa TT49480

@victoralmau
Copy link
Member Author

Ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 27, 2024
pedrobaeza
pedrobaeza approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and working. Just 2 minor comments.

partner_property/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
partner_property/readme/USAGE.rst Outdated Show resolved Hide resolved
@carolinafernandez-tecnativa
Copy link

If i go to Contacts and open Azure i got this error message:

image

@victoralmau
Copy link
Member Author

Thanks, fixed, can you check it again?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1785-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit af6d7b8 into OCA:16.0 Jun 27, 2024
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at acabdc2. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-partner_property branch June 27, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carolinafernandez-tecnativa carolinafernandez-tecnativa carolinafernandez-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victoralmau @carolinafernandez-tecnativa @OCA-git-bot @pedrobaeza