[17.0][FIX]partner_industry_secondary: Properly calculate industry's parent name #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelregidor
changed the title
manuelregidor
changed the title
HaraldPanten
approved these changes
Jun 19, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 4d42199. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, we noticed that some parents display names of the industries in the tree view were not calculated properly. For example:
However, the parent display name was properly displayed in the form view:
The reason is that "parent_id.display_name" dependency is missing in the _compute_display_name method in res.partner.industry dependencies list. After the fix, the parent display name is properly shown.