[9.0][PORT] port base location #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
changed the title
2 tasks
|
Maybe you can take the occasion to make some tests for this module. |
|
@pedrobaeza I would tend to merge as is, and focus on adding coverage reports first, so 👍 |
|
The coverage reports are already there... via coveralls.io |
|
hum, can't see it on this page ? |
|
It can be due to the high-traffic that is happening because the 9.0 branch migration, but it was working fine. |
|
@pedrobaeza Here we go all onchanges tested |
|
Thank you very much! Waiting for Travis result, 👍 |
yvaucher
force-pushed
the
9.0-port-base_location
branch
from
3464b8f
to
0afaa22
Compare
19 tasks
|
Travis is 💚 |
|
Perfect, I merge then |
pedrobaeza
added a commit
that referenced
this pull request
Oct 21, 2015
[9.0][PORT] port base location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.