[9.0] Upgrade Partner Gender module #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "author": "Odoo Community Association (OCA), Grupo ESOC", | ||
| "summary": "Add gender field to contacts", | ||
| "version": "9.0.1.0.0", | ||
| "author": "Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Why remove previous author? why not add Willow-IT?
There was a problem hiding this comment.
Happy to add original back, but I would have thought if all authors were listed, that would make it very long and unweildy - I thought that was the purpose of contributors, to some degree...
31 tasks
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # -*- coding: utf-8 -*- | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
There was a problem hiding this comment.
Copyright line is necessary don't remove it please
|
Just a thought: I wonder if it would be possible to auto complete the title from gender if not set or reversely. The same selection could appear on title with a boolean to know the default title to set for Male or Female. For now you can just fix my remarks and it will be good. Thanks for porting it. |
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.