9.0 [MIG] port partner_firstname #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 28, 2015 16:39
In the base module, a SQL constraint check that one is filled with the name of the partner. With this module, the name field is filled after creating so we have to remove. A python constraint checks that one is the firstname or lastname field filled.
| @@ -23,6 +23,7 @@ addon | version | summary | |||
| [partner_contact_gender](partner_contact_gender/) | 9.0.1.1.0 | Add gender field to contacts | |||
| [partner_contact_in_several_companies](partner_contact_in_several_companies/) | 9.0.1.0.0 | Allow to have one contact in several partners | |||
| [partner_contact_nationality](partner_contact_nationality/) | 9.0.1.0.0 | Add nationality field to contacts | |||
| [partner_firstname](partner_firstname/) | 9.0.2.0.0 | Split first name and last name for non company partners | |||
There was a problem hiding this comment.
This is not needed, the bot will update it automatically
|
Only thing which I see is missing in my PR is the new check for empty address for non contact addresses. Otherwise I feel there is more things in my PR than in yours (Updated contributor list, licenses, hide . So do you mind if I take my PR #238 as the basis to include your change to test the constraint on non contact addresses ? |
|
In fact there is now 3 PR with #215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.