[9.0] [MIG] base_location_geonames_import #253
Conversation
pedrobaeza
commented
Mar 12, 2016
pedrobaeza
commented
- Make module installable
- Short headers
- Update README.rst
- Improve test efficiency
|
FYI, yml will be deprecated https://www.odoo.com/fr_FR/groups/community-59/community-14056914 |
|
Thanks for the info, and I prefer Python files, but for this module, I take the easy path of only update existing YAML file. As in v9 is still supported, I prefer to let as is. |
|
|
||
| from openerp import models, fields, api, _ | ||
| from openerp.exceptions import Warning | ||
| from openerp.exceptions import Warning as UserError |
There was a problem hiding this comment.
Why do you have aliased 'Warning'?
There was a problem hiding this comment.
This is a guideline because Warning is deprecated
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm seeing that in v9 I should import directly UserError
There was a problem hiding this comment.
@lmignon, changed to use directly UserError
|
Thank you @pedrobaeza the code looks good to me. 👍 once Travis is green. |
… imported country Monaco country is very little and it allows to save some downloaded bytes plus making a test for entries deletion
|
@bealdav, with the advices from @alexis-via in #254, I have converted tests to Python, and improve a bit more the efficiency. |
|
👍 |
|
We can merge this one. |
