Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 add partner identifiers #255

Merged
merged 44 commits into from
Mar 19, 2016
Merged

Conversation

lmignon
Copy link
Sponsor Contributor

@lmignon lmignon commented Mar 15, 2016

Following the discussion on the contributors mailing list https://odoo-community.org/groups/contributors-15/contributors-36798?mode=thread&date_begin=&date_end=
Here it is a new module extrated from the comaptocamp repository that allows you to manage all sort of identification numbers which are assigned to a partner. The original module has been enhanced to allow you to specify a piece of python code called to validate the identification numbers.

@oca-clabot
Copy link

Hey @lmignon, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Gerhard Könighofer (no github login found)
  • Launchpad Translations on behalf of c2c (no github login found)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza
Copy link
Member

Can you squash at least all the "Launchpad automatic translations update."?

Known issues / Roadmap
======================

* If you want to search a partner by ID you will use advance search form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove first space

@lmignon lmignon force-pushed the 9.0-add_partner_identifiers-lmi branch from 887a9eb to 644e18b Compare March 16, 2016 10:51
@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Mar 16, 2016

@pedrobaeza @elicoidal all changes done

@pedrobaeza
Copy link
Member

Thank you very much! 👍

name = fields.Char(
string="ID Number", required=True,
help="The ID itself. For example, Driver License number of this "
"person")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add periods at the end of the sentences (several)

@lmignon
Copy link
Sponsor Contributor Author

lmignon commented Mar 16, 2016

@elicoidal I've spent a lot of time on this PR, feel free to make a PR on this one to fix the remaining issues. My original need could have been solved by adding one field on res.partner for the Belgium id number in my project.

@JonathanNEMRY
Copy link

👍

@elicoidal
Copy link

@lmignon no problem! I will make a follow up PR.
Thanks for the initiative and for the excellent work

@elicoidal
Copy link

👍

The number must be validated also when we change the category
@laetitia-gangloff
Copy link

👍

elicoidal added a commit that referenced this pull request Mar 19, 2016
@elicoidal elicoidal merged commit eacc6af into OCA:9.0 Mar 19, 2016
@lmignon lmignon deleted the 9.0-add_partner_identifiers-lmi branch May 30, 2016 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants