-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0 add partner identifiers #255
Conversation
Hey @lmignon, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Can you squash at least all the "Launchpad automatic translations update."? |
To fix fake statistics.
Known issues / Roadmap | ||
====================== | ||
|
||
* If you want to search a partner by ID you will use advance search form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove first space
887a9eb
to
644e18b
Compare
@pedrobaeza @elicoidal all changes done |
Thank you very much! 👍 |
name = fields.Char( | ||
string="ID Number", required=True, | ||
help="The ID itself. For example, Driver License number of this " | ||
"person") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add periods at the end of the sentences (several)
@elicoidal I've spent a lot of time on this PR, feel free to make a PR on this one to fix the remaining issues. My original need could have been solved by adding one field on res.partner for the Belgium id number in my project. |
👍 |
@lmignon no problem! I will make a follow up PR. |
👍 |
The number must be validated also when we change the category
👍 |
Following the discussion on the contributors mailing list https://odoo-community.org/groups/contributors-15/contributors-36798?mode=thread&date_begin=&date_end=
Here it is a new module extrated from the comaptocamp repository that allows you to manage all sort of identification numbers which are assigned to a partner. The original module has been enhanced to allow you to specify a piece of python code called to validate the identification numbers.