New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] Migration partner_contact_birthdate partner_contact_gender part… #315

Merged

pedrobaeza merged 9 commits into OCA:10.0 from cvinh:10.0-migrate-partner-contact-birthdate

Nov 12, 2016

cvinh commented Oct 16, 2016

…ner_contact_personal_information_page to v10

Invitu added 2 commits

October 15, 2016 17:16


          [MIG] Migration partner_contact_birthdate partner_contact_gender part…

e404fde

…ner_contact_personal_information_page to v10


          [IMP] Add French Translation to partner_contact_gender

e569495

cvinh mentioned this pull request

Migration to version 10.0 #309

Closed

38 tasks


          [FIX] Fix coveralls

57fc924

Garamotte commented Oct 16, 2016

As said in #307, you should add the post init hook to call _birthdate_install in the partner_contact_birthdate module, and remove the yaml file.

Also, I think you should split the migration commit, one per module.

Otherwise, 👍 (code review + functional tests)

rafaelbn requested changes

View reviewed changes

Member

rafaelbn left a comment

Hi @invitu thanks for migration. But please make a single PR per module. It helps a lot 😄

partner_contact_birthdate/__manifest__.py

@@ @@ -4,7 +4,7 @@ @@
               {
                   "name": "Contact's birthdate",
-                  "version": "9.0.1.0.0",
+                  "version": "10.0.1.0.0",
                   "author": "Jairo Llopis,"

Member

rafaelbn Oct 16, 2016

Please add Tecnativa, we join all together in a new team.

partner_contact_gender/__manifest__.py

@@ @@ -5,7 +5,7 @@ @@
               {
                   "name": "Contact gender",
                   "summary": "Add gender field to contacts",
-                  "version": "9.0.1.1.0",
+                  "version": "10.0.1.1.0",
                   "category": "Customer Relationship Management",
                   "website": "https://odoo-community.org/",

Member

rafaelbn Oct 16, 2016

Please change to https://www.tecnativa.com as we are in the new team

partner_contact_gender/__manifest__.py

@@ @@ -5,7 +5,7 @@ @@
               {
                   "name": "Contact gender",
                   "summary": "Add gender field to contacts",
-                  "version": "9.0.1.1.0",
+                  "version": "10.0.1.1.0",
                   "category": "Customer Relationship Management",
                   "website": "https://odoo-community.org/",
                   "author": "Grupo ESOC, Odoo Community Association (OCA)",

Member

rafaelbn Oct 16, 2016

Please add Tecnativa, we join all together in a new team

rafaelbn added the work in progress label

rafaelbn added this to the 10.0 milestone

rafaelbn added needs review and removed work in progress labels

Member

pedrobaeza commented Oct 16, 2016

@rafaelbn, in this case, we can accept all the modules together are they are simple and bound.

Member

rafaelbn commented Oct 16, 2016

Sorry I put need fixing label until attended #307 (comment) thanks!

rafaelbn added needs fixing and removed needs review labels

Member

rafaelbn commented Oct 16, 2016

OK @pedrobaeza just minor comments and #307 (comment)


          [FIX] Use post_init_hook and minor fixes with author

50c8791

Author

cvinh commented Oct 19, 2016

I did a PR for those 3 modules because they are small and depend on partner_contact_personal_information_page

requested fixes are commited

Invitu added 4 commits

October 19, 2016 00:03


          [FIX] minor fixes with author

577b167


          [FIX] syntax fix

ba3ba21


          [FIX] forgot to add hooks.py in Git

2123b9b


          [FIX] add licence in __manifest__.py

9aac66f

lasley mentioned this pull request

[MIG][10.0] partner_contact_birthdate #331

Closed

lasley approved these changes

View reviewed changes

Contributor

lasley left a comment

LGTM code & test

rafaelbn approved these changes

View reviewed changes

rafaelbn added needs review and removed needs fixing labels

rafaelbn approved these changes

View reviewed changes

Member

rafaelbn left a comment

@pedrobaeza ready to merge, tested in runbot

rafaelbn reviewed

View reviewed changes

partner_contact_birthdate/__manifest__.py

                   "author": "Jairo Llopis,"
+                            "Tecnativa,"
                             "Odoo Community Association (OCA)",

Member

rafaelbn Nov 12, 2016

Shouldn't it be "Jairo Llopis, Tecnativa, Odoo Community Association (OCA)" ?

lasley mentioned this pull request

[IMP][10.0] medical: Simplify models LasLabs/vertical-medical#34

Merged

1 task


          [FIX] partner_contact_birthdate: Fix author

0fabd4a

jeroenev pushed a commit to jeroenev/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

fac4fa3

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

jeroenev pushed a commit to jeroenev/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

439e7cb

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

jeroenev pushed a commit to jeroenev/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

jeroenev pushed a commit to jeroenev/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

397a110

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

jeroenev pushed a commit to jeroenev/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

84709b5

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

ermannognan pushed a commit to ermannognan/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

c6621f4

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

chienandalu pushed a commit to Tecnativa/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

ec9b828

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

3358a46

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

newtratip pushed a commit to ecosoft-odoo/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

dbfe32e

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

newtratip pushed a commit to ecosoft-odoo/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

16f506f

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

newtratip pushed a commit to ecosoft-odoo/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

804b8c9

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

b6c4a04

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

9268e56

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

holdenrehg pushed a commit to holdenrehg/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

3dd9ef9

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

OCA-git-bot pushed a commit to holdenrehg/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

a181d4b

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

carmenbianca pushed a commit to coopiteasy/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

97d9fb6

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

marielejeune pushed a commit to acsone/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

d7b4285

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

carmenbianca pushed a commit to coopiteasy/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

77fd113

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

victor-champonnois pushed a commit to coopiteasy/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

d2577be

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

2cf6f7f

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

ed69a01

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

6fb2e01

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

quoc-pn pushed a commit to quoc-pn/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

59dbb84

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

OCA-git-bot pushed a commit to Daemo00/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

f692d59

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Daemo00 pushed a commit to Daemo00/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

3b097bd

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

edlopen pushed a commit to moduon/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

f24e014

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

edlopen pushed a commit to moduon/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

6e9415b

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

edlopen pushed a commit to moduon/partner-contact that referenced this pull request


          Migration partner_contact_birthdate partner_contact_gender part… (OCA…

85e9259

…#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

edlopen pushed a commit to moduon/partner-contact that referenced this pull request


          [MIG] Migration partner_contact_birthdate partner_contact_gender part… (

5af687c

OCA#315)

[MIG] Migration partner_contact_birthdate partner_contact_gender partner_contact_personal_information_page to v10

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment