[9.0] [MIG] partner_contact_lang #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=========================== Manage language in contacts =========================== Odoo by default propagate language field to the created contacts from their form, but it doesn't allow to change it once created. This module fills this gap, and also provides other facilities for the contact language management: * Put the language of the parent company when the contact doesn't have a language and this parent company is assigned. * When the company changes the language, it fills with the same language all the contacts that don't have any. Usage ===== Go to any partner that is a company and has contacts. Click on one contact and you will be able to edit the language.
|
@rousseldenis thanks for your reviews. The icon is a custom one I prepared for the module. I think it's more convenient than the generic one 😉 |
|
@pedrobaeza I thought it was the convention to use OCA icon in every module |
rousseldenis
approved these changes
Jan 24, 2017
|
No, the only convention is to not put any commercial trademark or logo, but you can:
I always try to put some icons when I have the inspiration for a clear concept, hehe. Also with the raise of the mobile interface (web_responsive OCA module or web_enterprise module), the icon for the main app is starting to be important. For example, I plan to create an icon for connector, queue and custom info apps. |
|
@cubells, please review |
cubells
approved these changes
Jan 24, 2017
leemannd
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa