[9.0][Port] mig partner changeset #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
3 times, most recently
from
36b9ef7
to
a59fbe2
Compare
leemannd
changed the title
|
@pedrobaeza @guewen @damdam-s It is not anymore in WIP state |
leemannd
commented
Dec 7, 2016
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <openerp> | |||
| <data> | |||
There was a problem hiding this comment.
Not sure about this one. Is it possible with <odoo> to have a part of the records with noupdate and a part without?
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
from
a59fbe2
to
30379e5
Compare
jgrandguillaume
approved these changes
Dec 12, 2016
damdam-s
approved these changes
Dec 12, 2016
|
I know I'm always asking the same, but can you squash all that useless commits from the same person? |
Add translations Add test coverage for caching of changeset rules Add unique constraint (model_id, field_id) on rules Add rules in demo data Put the security groups links in noupdate Put keep the groups in a noupdate=0 section so the records in ir.model.data will still be modifiable by other modules. Store the source of a changeset Differentiate rules according to their origin Rules are applied also for manual edition Action is required Do not keep recordsets in ormcache Because they would be unreadable as soon as the cursor is closed. Instead, we keep only the id and the record is browsed for every new environment. Remove useless 'model_id' on changeset rules model_id has been removed Remove reference to the model_name on rules Because the model has been removed earlier (dead code) Fix issue when applying empty many2one Do not create changesets on moved contacts As we just created the contact with a 'copy' we don't want to have a changeset for the initialization values Update translations Use a selection widget on source model Adapt for inclusion in OCA Rename 'Pending Changesets' to 'Changes' It's shorter Add screenshots Do not create a changeset when both sides are empty But have a different type (e.g. False and '')
OCA Transbot updated translations from Transifex
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
from
30379e5
to
3cc8c6d
Compare
|
@pedrobaeza I usually don't feel comfortable with modifying the git history of other people, but I'll do it in the beginning when porting a module. |
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
2 times, most recently
from
db0421e
to
5e68e90
Compare
pedrobaeza
requested changes
Dec 15, 2016
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/134/8.0 |
| <https://github.com/OCA/ | ||
| partner-contact/issues/new?body=module:%20 | ||
| partner_changeset%0Aversion:%20 | ||
| 8.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. |
There was a problem hiding this comment.
And remove this part according last template
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
from
5e68e90
to
f79626b
Compare
|
@pedrobaeza Corrected |
|
Travis is failing |
Add changes from previous port fix menu fix _compute from previous import & tests
leemannd
force-pushed
the
9.0-mig-partner_changeset
branch
from
f79626b
to
02d6a5b
Compare
|
@pedrobaeza error in tests linked to the fact that cache is not updated during the same transaction. It should be better now. |
pedrobaeza
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
As #213 is not going forward, there is a proposition to do it here.
[EDIT]