Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][10.0] Add partner_contact_configuration module #377

Merged
merged 5 commits into from
Feb 16, 2017
Merged

[ADD][10.0] Add partner_contact_configuration module #377

merged 5 commits into from
Feb 16, 2017

Conversation

rousseldenis
Copy link
Sponsor Contributor

No description provided.

adrienpeiffer
adrienpeiffer approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@adrienpeiffer adrienpeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jan 27, 2017

@rousseldenis Good Idea. Once merged it will be possible to remove the annoying dependency on sale_team in partner_indentification and ....

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jan 27, 2017

👍

@rousseldenis
Copy link
Sponsor Contributor Author

@lmignon That was the purpose, thanks!

pedrobaeza
pedrobaeza reviewed Jan 27, 2017
View reviewed changes
partner_contact_configuration/README.rst
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/134/10.0

.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@pedrobaeza
Copy link
Member

But depending on module contacts is similar than depending on sales_team. The latter has also dependency on mail, but it's a dependency that you are going to install for sure, and I would even prefer it because I have only one app on the top menu: Sales, instead of Sales and Contacts. Any reason that I don't get?

@rousseldenis
Copy link
Sponsor Contributor Author

@pedrobaeza In some cases, you don't want to have Sales menu. Moreover, your users don't have necessarily sales rights (that is mandatory to have menus in that case).
You want just to manage contacts ... so, this is the purpose of this module

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 27, 2017 •
edited
Loading

OK, got it. It would be good to have this explanation on the README too.

@lmignon
Copy link
Sponsor Contributor

lmignon commented Feb 16, 2017

This one seems ready to merge...

@pedrobaeza pedrobaeza merged commit c12de0e into OCA:10.0 Feb 16, 2017
@pedrobaeza
Copy link
Member

Here you have!

luismontalba pushed a commit to luismontalba/partner-contact that referenced this pull request Mar 12, 2019
@rousseldenis @luismontalba
[ADD][10.0] Add partner_contact_configuration module (OCA#377)
af3cf8a
Laurent-Corron pushed a commit to acsone/partner-contact that referenced this pull request Nov 6, 2019
@rousseldenis
[ADD][10.0] Add partner_contact_configuration module (OCA#377)
dd58bd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@lmignon lmignon lmignon approved these changes

@adrienpeiffer adrienpeiffer adrienpeiffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rousseldenis @lmignon @pedrobaeza @adrienpeiffer